Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing paginator for DynamoDB ListTagsOfResource #2873

Open
2 tasks
thieman opened this issue Aug 7, 2023 · 6 comments
Open
2 tasks

Missing paginator for DynamoDB ListTagsOfResource #2873

thieman opened this issue Aug 7, 2023 · 6 comments
Assignees
Labels
bug This issue is a bug. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@thieman
Copy link

thieman commented Aug 7, 2023

Describe the feature

DynamoDB's ListTagsOfResource is a paginated operation, returning a list and accepting NextToken in its input args. However, a Paginator is not provided for it in the SDK. Instead, callers need to call the client's ListTagsOfResource multiple times. We have the Paginator construct for exactly this use case, not sure why this method doesn't provide one.

Use Case

Anyone wanting to get tags from DynamoDB resources will benefit from this, as now they have to paginate manually

Proposed Solution

Implement the same Paginator pattern used throughout the SDK, but for this method

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

N/A

Go version used

N/A

@thieman thieman added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 7, 2023
@RanVaknin RanVaknin self-assigned this Aug 14, 2023
@RanVaknin
Copy link
Contributor

Hi @thieman ,

Thanks for opening this issue.

This paginator is missing because the Dynamo service team did not specify ListTagsOfResource in their model as a paginated operation.

I have created an internal ticket with the Dynamo service team to add this paginator. Im going to transfer this to the cross-sdk repo for further monitoring.

Thanks again,
Ran~

P96938372

@RanVaknin RanVaknin added service-api This issue is due to a problem in a service API, not the SDK implementation. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 14, 2023
@RanVaknin RanVaknin transferred this issue from aws/aws-sdk-go-v2 Aug 14, 2023
@RanVaknin RanVaknin added bug This issue is a bug. and removed feature-request A feature should be added or improved. labels Aug 14, 2023
@RanVaknin RanVaknin assigned yasminetalby and unassigned RanVaknin Sep 27, 2023
@ashishdhingra
Copy link

Contacted service team for update. Awaiting response.

@ashishdhingra
Copy link

Reached out to service team requesting for an update.

@ashishdhingra
Copy link

Followed up again with the service team oncall. Awaiting update.

@ashishdhingra
Copy link

Service team came back with following response:

ListTagsOfResource does not support pagination at the API level, this is not a model issue. Tags are limited to 50 per resource and therefore there's no need for pagination.

Provided them some instances of ListTagsOfResource in AWS services which support pagination:

Awaiting update.

@ashishdhingra
Copy link

Followed up with service team, waiting response.

@zshzbh zshzbh transferred this issue from aws/aws-sdk Oct 30, 2024
@RanVaknin RanVaknin assigned RanVaknin and unassigned ashishdhingra Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

4 participants