Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecommit implement GetChanges #2876

Closed
2 tasks
reckerdaniel opened this issue Jun 10, 2022 · 4 comments
Closed
2 tasks

Codecommit implement GetChanges #2876

reckerdaniel opened this issue Jun 10, 2022 · 4 comments
Assignees
Labels
feature-request A feature should be added or improved. service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@reckerdaniel
Copy link

Describe the feature

I want to get a list of changes in a pullrequest. Right now there is a GetDifferences function but that lists all the differences between two different commits. i want to only list the changes that a given pullrequest has made without including the differences in main that were added by other teams.

It's possible this already exists but i wasn't able to find it in the documentation.
https://github.com/aws/aws-sdk-go/tree/v1.44.31/service/codecommit

Use Case

We want to use the list of changes in a pullrequest to generate the approver list. we map changes within a specified folder to have specific approvers. If we are able to get the changes a pullrequest has we can limit our approver list just to the people we need. currently using GetDifferences it would include any difference between main and a Commit ID so we include changes outside of the Pullrequest therefore requesting too many approvers.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

aws-sdk-go-v2

Environment details (Version of Go (go version)? OS name and version, etc.)

go version go1.15.3 windows/amd64

@reckerdaniel reckerdaniel added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 10, 2022
@vudh1
Copy link
Contributor

vudh1 commented Jun 17, 2022

Hi, thanks for bringing this up. We have discussed and this feature is a feature for service API that the SDK cannot implement. I will transfer this to the correct repo and reach out to the service team.

@vudh1 vudh1 added service-api This issue is due to a problem in a service API, not the SDK implementation. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 17, 2022
@vudh1 vudh1 transferred this issue from aws/aws-sdk-go Jun 17, 2022
@vudh1 vudh1 self-assigned this Jun 17, 2022
@vudh1 vudh1 assigned RanVaknin and unassigned vudh1 Sep 9, 2022
@RanVaknin RanVaknin assigned bhoradc and unassigned RanVaknin Sep 26, 2023
@bhoradc
Copy link

bhoradc commented Apr 24, 2024

V1362377973

@zshzbh zshzbh transferred this issue from aws/aws-sdk Oct 30, 2024
@zshzbh zshzbh closed this as completed Oct 30, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@zshzbh
Copy link

zshzbh commented Oct 30, 2024

Hey there,

Got back from service team - No new changes are planned in CodeCommit. Closing this issue. Please let us know if there's anything else.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

5 participants