Fix eventbridge tests #2197
Merged
Fix eventbridge tests #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
approved these changes
Jul 20, 2023
aajtodd
approved these changes
Jul 20, 2023
| @@ -229,6 +234,30 @@ func (c *Client) invokeOperation(ctx context.Context, opID string, params interf | |||
|
|
|||
| type noSmithyDocumentSerde = smithydocument.NoSerde | |||
|
|
|||
| type LegacyEndpointContextSetter struct { | |||
There was a problem hiding this comment.
correctness: Why is this type public?
There was a problem hiding this comment.
good call, will privatize in next PR
| @@ -512,3 +533,32 @@ func addRequestResponseLogging(stack *middleware.Stack, o Options) error { | |||
| LogResponseWithBody: o.ClientLogMode.IsResponseWithBody(), | |||
| }, middleware.After) | |||
| } | |||
|
|
|||
| type EndpointDisableHTTPSMiddleware struct { | |||
There was a problem hiding this comment.
correctness: Same question, why public?
There was a problem hiding this comment.
will privatize in next PR
isaiahvita
added a commit
to isaiahvita/aws-sdk-go-v2
that referenced
this pull request
Jul 25, 2023
isaiahvita
added a commit
that referenced
this pull request
Jul 25, 2023
isaiahvita
added a commit
that referenced
this pull request
Jul 27, 2023
isaiahvita
added a commit
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following changes which got all of eventbridge endpoint customization unit tests to pass
GetRequiresLegacyEndpointscontext checker in theeventbridgeendpoint customizations