Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken MRAP tests #2203

Merged
merged 8 commits into from
Jul 24, 2023
Merged

Conversation

isaiahvita
Copy link
Contributor

  1. Fix test case custom endpoint with hostname immutable. The problem was that for custom v1 resolvers with immutable hostname. we were previously disallowing arn buckets. but MRAP buckets are ARNs, so i modified the serialize immutable hostname middleware to allow MRAP buckets (which are identified as region-less).
  2. Fixed several tests which were previously succeeding but erroring out on EP20. Confirmed in SEP that these tests shouldnt be succeeding and that EP20's behavior is more correctly following the SEP.
  3. For v4a, the EP20 middleware was setting the signer name as sigv4a when the signer middleware was switchcasing off of SigV4A. so i modified codegen to set SigV4A instead
  4. Fixed a couple of mismatched error messages
  5. Fixed some broken unit tests for same issue as convert s3 handle_200_error_test into an actual unit test #2174

@isaiahvita isaiahvita requested a review from a team as a code owner July 24, 2023 17:06
@isaiahvita isaiahvita merged commit e06caa6 into aws:feat-ep20 Jul 24, 2023
1 check passed
isaiahvita added a commit to isaiahvita/aws-sdk-go-v2 that referenced this pull request Jul 25, 2023
isaiahvita added a commit that referenced this pull request Jul 25, 2023
isaiahvita added a commit that referenced this pull request Jul 27, 2023
isaiahvita added a commit that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants