don't serde the bucket #2204
Merged
don't serde the bucket #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaiahvita
approved these changes
Jul 24, 2023
lucix-aws
commented
Jul 25, 2023
| @@ -81,6 +81,10 @@ generate: smithy-generate update-requires gen-repo-mod-replace update-module-met | |||
| gen-config-asserts gen-internal-codegen copy-attributevalue-feature gen-mod-dropreplace-smithy-. min-go-version-. \ | |||
| tidy-modules-. add-module-license-files gen-aws-ptrs format | |||
|
|
|||
| generate-tmpreplace-smithy: smithy-generate update-requires gen-repo-mod-replace update-module-metadata smithy-annotate-stable \ | |||
There was a problem hiding this comment.
I didn't intend to add this but I've been using it heavily during development.
Essentially it temporarily replaces the smithy-go dependency to point to your branch version. The format step will fail on make generate if you're consuming smithy-go APIs that aren't yet released otherwise.
aajtodd
approved these changes
Jul 25, 2023
isaiahvita
pushed a commit
to isaiahvita/aws-sdk-go-v2
that referenced
this pull request
Jul 25, 2023
isaiahvita
pushed a commit
that referenced
this pull request
Jul 25, 2023
isaiahvita
pushed a commit
that referenced
this pull request
Jul 27, 2023
isaiahvita
pushed a commit
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps
httpLabelwithNoSerializeon relevant buckets so we don't inadvertently add them into the request document (which we were doing after removinghttpLabel).