Fix retrymaxattempts functional options #2253
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened for #2251
Currently the right side of the if statement is always true, resulting in the function returning, instead of setting the retryer with the user supplied RetryMaxAttempts.
Used this test code to verify the bug:
In this driver code, Im mocking a 500 response from the service which is a retryable error to force the SDK client to retry.
Before the change, the client retries only 3 times (the default value):
After the altering the code-generated cloudwatch api_client.go the behavior is correct:
Which warrants a code change at the source which is the codegen folder.