From e5b4abe760a6b29888e226999156660e04cc79f1 Mon Sep 17 00:00:00 2001 From: Ran Vaknin Date: Tue, 22 Aug 2023 09:56:54 -0700 Subject: [PATCH 1/2] fix(codegen:client-config) removing incorrect condition --- .../amazon/smithy/aws/go/codegen/AddAwsConfigFields.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AddAwsConfigFields.java b/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AddAwsConfigFields.java index 493c1d62857..025722e396f 100644 --- a/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AddAwsConfigFields.java +++ b/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AddAwsConfigFields.java @@ -377,7 +377,7 @@ private void writeRetryMaxAttemptsFinalizeResolver(GoWriter writer) { writer.write(""" func $finalizeResolveName:L(o *Options, client Client) { - if v := o.RetryMaxAttempts; v == 0 || v == client.options.RetryMaxAttempts { + if v := o.RetryMaxAttempts; v == 0 { return } From ae313dd221c26b1360343c8973e4206bb9c362a8 Mon Sep 17 00:00:00 2001 From: Ran Vaknin Date: Tue, 22 Aug 2023 09:57:54 -0700 Subject: [PATCH 2/2] added changelog --- .changelog/6de4cab7037841c59f91b3db81edee9c.json | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .changelog/6de4cab7037841c59f91b3db81edee9c.json diff --git a/.changelog/6de4cab7037841c59f91b3db81edee9c.json b/.changelog/6de4cab7037841c59f91b3db81edee9c.json new file mode 100644 index 00000000000..0f17f708ffa --- /dev/null +++ b/.changelog/6de4cab7037841c59f91b3db81edee9c.json @@ -0,0 +1,8 @@ +{ + "id": "6de4cab7-0378-41c5-9f91-b3db81edee9c", + "type": "bugfix", + "description": "removed incorrect condition preventing setting retryMaxAttempts via functional options", + "modules": [ + "codegen" + ] +} \ No newline at end of file