Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend new tracing instrumentation for the SDK #2766

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

lucix-aws
Copy link
Contributor

Tracks and extends changes in aws/smithy-go#534

Tracing component of #1744

  • wraps the retry loop in a span (an outer one for retry loop, and then span per-attempt)
  • adds the following span attributes
    • operation.attempt - the number of the current attempt, starting at 1
    • aws.request_id - aws request ID (set per attempt)
    • aws.extended_request_id - additional request ID returned from some services (i.e. just s3 right now)
    • net.peer.name - the host:port combination that the HTTP client DialContext()ed
    • net.peer.host - IP address returned from the inner dial
    • net.peer.port - port returned from the inner dial
    • net.peer.addr - raw ip:port combination that the dial returned, if it couldn't be parsed into host/port separately for some reason

@lucix-aws lucix-aws requested a review from a team as a code owner August 29, 2024 17:17
@lucix-aws
Copy link
Contributor Author

lucix-aws commented Aug 29, 2024

taking a look at test failures

[EDIT] fixed, I think

# stripped-down regenerate script that eliminates a lot of the cruft you don't
# need in development (that takes time)
# modify this with whatever service you're working on
generate-dev: smithy-generate update-requires gen-repo-mod-replace gen-mod-replace-smithy-config gen-mod-replace-smithy-aws gen-mod-replace-smithy-service_s3 update-module-metadata smithy-annotate-stable \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@lucix-aws lucix-aws merged commit 2b1f235 into feat-observability Sep 3, 2024
11 checks passed
@lucix-aws lucix-aws deleted the feat-observability-tracing branch September 3, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants