-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend new tracing instrumentation for the SDK #2766
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[EDIT] fixed, I think |
Madrigal
approved these changes
Aug 30, 2024
# stripped-down regenerate script that eliminates a lot of the cruft you don't | ||
# need in development (that takes time) | ||
# modify this with whatever service you're working on | ||
generate-dev: smithy-generate update-requires gen-repo-mod-replace gen-mod-replace-smithy-config gen-mod-replace-smithy-aws gen-mod-replace-smithy-service_s3 update-module-metadata smithy-annotate-stable \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
lucix-aws
added a commit
that referenced
this pull request
Sep 6, 2024
lucix-aws
added a commit
that referenced
this pull request
Sep 11, 2024
lucix-aws
added a commit
that referenced
this pull request
Sep 18, 2024
lucix-aws
added a commit
that referenced
this pull request
Sep 18, 2024
lucix-aws
added a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks and extends changes in aws/smithy-go#534
Tracing component of #1744
operation.attempt
- the number of the current attempt, starting at 1aws.request_id
- aws request ID (set per attempt)aws.extended_request_id
- additional request ID returned from some services (i.e. just s3 right now)net.peer.name
- the host:port combination that the HTTP clientDialContext()
ednet.peer.host
- IP address returned from the inner dialnet.peer.port
- port returned from the inner dialnet.peer.addr
- raw ip:port combination that the dial returned, if it couldn't be parsed into host/port separately for some reason