Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add HTTP client metrics from smithy-go #2815

Merged
merged 2 commits into from
Oct 3, 2024
Merged

add HTTP client metrics from smithy-go #2815

merged 2 commits into from
Oct 3, 2024

Conversation

lucix-aws
Copy link
Contributor

Closes #2809

@lucix-aws lucix-aws requested a review from a team as a code owner October 3, 2024 20:08
Madrigal
Madrigal reviewed Oct 3, 2024
View reviewed changes
internal/protocoltest/restxml/api_client.go
resolveMeterProvider(&options)

resolveTracerProvider(&options)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting crazy by this change being made whenever I regenerated my changes :P

Madrigal
Madrigal approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@Madrigal Madrigal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checked that some of the api_client.go had the right namespace added to them

@lucix-aws lucix-aws merged commit 280579a into main Oct 3, 2024
12 checks passed
@lucix-aws lucix-aws deleted the feat-httpmetrics branch October 3, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madrigal Madrigal Madrigal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collect HTTP client metrics
2 participants
@lucix-aws @Madrigal