add loadoptions to configure BaseEndpoint #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madrigal
reviewed
Oct 15, 2024
| @@ -0,0 +1,187 @@ | |||
| package main | |||
There was a problem hiding this comment.
this package being main is tripping the integ tests
found packages s3 (api_test.go) and main (endpoint_url_test.go) in /codebuild/output/src1559507751/src/github.com/aws/aws-sdk-go-v2/service/internal/integrationtest/s3
There was a problem hiding this comment.
I also 100% did not apply the integration test flag so that needs fixed.
|
I didn't prefix the new test with |
wty-Bryant
approved these changes
Oct 15, 2024
Madrigal
approved these changes
Oct 15, 2024
| "AWS_ENDPOINT_URL_S3": "https://service-env.com", | ||
| }, | ||
| SharedConfig: ` | ||
| [default] |
There was a problem hiding this comment.
thought, non blocking: I understand why multi-line strings are like this, but boy are they not pretty to read
| s3 = | ||
| endpoint_url = https://service-cfg.com | ||
| `, | ||
| Expect: "https://service-cfg.com", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in-code hook for configuring a global endpoint override in config loading.
Also adds an integration test that verifies the SEP-defined precedence of endpoint overrides with actual env and shared config in place.
Closes #2422
Related ekristen/aws-nuke#376