Fix ecs.awsAwsjson11_deserializeErrorAccessDeniedException #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the bug that doesn't display an error message when some ECS operations fail due to AccessDeniedException.
3 tasks
|
Hi @abicky , Your root causing seems to be correct, however we can't accept changes to the model files found under the codegen folder. These are directly code generated from the upstream API model which is considered "The source of truth". We will have to upstream this request on your behalf. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2859.
I've changed service/ecs/deserializers.go by running
make allafter I edited codegen/sdk-codegen/aws-models/ecs.json.Although I've read the following notice, I thought it would be better to create a PR:
If there are any problems, please feel free to close this PR.