User Agent metrics #3031
Merged
User Agent metrics #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md |
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md |
alextwoods
reviewed
May 28, 2024
alextwoods
reviewed
May 30, 2024
gems/aws-sdk-core/lib/aws-sdk-core/plugins/client_metrics_send_plugin.rb
Show resolved
Hide resolved
jterapin
reviewed
May 30, 2024
gems/aws-sdk-core/lib/aws-sdk-core/plugins/client_metrics_send_plugin.rb
Show resolved
Hide resolved
alextwoods
approved these changes
Jun 3, 2024
alextwoods
reviewed
Jun 3, 2024
|
Yes, we do need a minimum core version. Good call out. New service could have old core and not have the metric() method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps user agent to 2.1 and uses new m/ tag for gathering metrics. Metrics is block based similar to how feature was.
We also remove cfg/ and ft/ usage.
We also need to re-arrange how the user agent plugin is registered - also fix CSM ordering issue discovered during this process.