Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service specific protocol tests #3049

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Service specific protocol tests #3049

merged 7 commits into from
Jun 19, 2024

Conversation

mullermp
Copy link
Contributor

@mullermp mullermp commented Jun 18, 2024

Handwritten service tests from https://github.com/smithy-lang/smithy/blob/main/smithy-aws-protocol-tests/model/

Also a few related fixes.

Copy link

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md

@mullermp mullermp requested review from alextwoods and jterapin June 18, 2024 22:29
Copy link
Contributor

@jterapin jterapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the comment reference to the smithy version of these test cases.

build_tools/services.rb Outdated Show resolved Hide resolved
@mullermp mullermp merged commit 24f1619 into version-3 Jun 19, 2024
28 checks passed
@mullermp mullermp deleted the service-protocol-tests branch June 19, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants