Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol tests with new changes to CBOR and Rest #3123

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Fix protocol tests with new changes to CBOR and Rest #3123

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0ff6ff4
Always add accept header for cbor protocol
mullermp Oct 9, 2024
5a58eff
Add changelog
mullermp Oct 9, 2024
aab4c5f
Test with new protocol tests
mullermp Oct 18, 2024
0d41ad0
Move cbor engine to rpc v2 namespace
mullermp Oct 18, 2024
90bbec1
Merge branch 'version-3' into cbor-accept
mullermp Oct 18, 2024
d260483
Fix new protocol tests
mullermp Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gems/aws-sdk-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Unreleased Changes
------------------

* Issue - Fix RPCv2 protocol to always send an Accept header for CBOR.

3.209.1 (2024-09-25)
------------------

Expand Down
4 changes: 3 additions & 1 deletion gems/aws-sdk-core/lib/aws-sdk-core/rpc_v2/content_type_handler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ def call(context)
accept =
if eventstream_output?(context)
'application/vnd.amazon.eventstream'
else
'application/cbor'
end

headers = context.http_request.headers
headers['Content-Type'] ||= content_type if content_type
headers['Accept'] ||= accept if accept
headers['Accept'] ||= accept
@handler.call(context)
end

Expand Down
Loading