From 9c158f3e2b0d7e2c9e2f60114651160034d54ac5 Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:13:31 -0800 Subject: [PATCH 01/14] Metrics for amazonq Unit test generation --- telemetry/definitions/commonDefinitions.json | 268 +++++++++++++++++++ 1 file changed, 268 insertions(+) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index dc309254..38fa2a71 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -178,6 +178,16 @@ "type": "int", "description": "The amount of time required for the build to complete (in seconds)." }, + { + "name": "buildStatus", + "type": "string", + "allowedValues": [ + "SUCCESS", + "FAILED", + "CANCELLED" + ], + "description": "The amount of time required for the build to complete (in seconds)." + }, { "name": "buildSystemVersion", "type": "string", @@ -1412,11 +1422,41 @@ ], "description": "The Lambda Package type of the function" }, + { + "name": "latencyOfClientSideBuild", + "type": "int", + "description": "Time from start to end of Client-side build." + }, + { + "name": "latencyOfGeneratingTests", + "type": "int", + "description": "Time from start to end of Generating unit tests" + }, { "name": "language", "type": "string", "description": "Language used for the project." }, + { + "name": "linesOfCodeGenerated", + "type": "int", + "description": "Number of lines of code generated" + }, + { + "name": "linesOfCodeAccepted", + "type": "int", + "description": "Number of lines of code accepted" + }, + { + "name": "charsOfCodeGenerated", + "type": "int", + "description": "Number of characters of code generated" + }, + { + "name": "charsOfCodeAccepted", + "type": "int", + "description": "Number of characters of code accepted" + }, { "name": "loadFileTime", "type": "int", @@ -1457,6 +1497,31 @@ "type": "int", "description": "Number of generations before the user accepted or rejected" }, + { + "name": "numberOfBuildExecuted", + "type": "int", + "description": "Number of build executed in unit test generation build loop" + }, + { + "name": "numberOfBuildFailed", + "type": "int", + "description": "Number of build failures in unit test generation build loop" + }, + { + "name": "numberOfBuildPassed", + "type": "int", + "description": "Number of build succeeded in unit test generation build loop" + }, + { + "name": "numberOfUnitTestCasesGenerated", + "type": "int", + "description": "Number of unit test cases generated" + }, + { + "name": "numberOfUnitTestCasesAccepted", + "type": "int", + "description": "Number of unit test cases accepted" + }, { "name": "oldVersion", "type": "string", @@ -1675,6 +1740,11 @@ "type": "int", "description": "The number of successful operations" }, + { + "name": "supportedLanguage", + "type": "boolean", + "description": "supported language" + }, { "name": "syncedResources", "type": "string", @@ -1694,6 +1764,16 @@ "type": "string", "description": "Generic name of a template" }, + { + "name": "testGenerationJobGroupName", + "type": "string", + "description": "Unit test generation job group name" + }, + { + "name": "testGenerationJobId", + "type": "string", + "description": "Unit test generation job id" + }, { "name": "toolId", "type": "string", @@ -1732,6 +1812,21 @@ "type": "string", "description": "User selection from a predefined menu (not user-provided input). See also `action`." }, + { + "name": "unitTestGenerationBuildPayloadBytes", + "type": "int", + "description": "The uncompressed payload size in bytes of the source files in customer project context sent for unit test generation" + }, + { + "name": "unitTestGenerationBuildZipFileBytes", + "type": "int", + "description": "The compressed payload size of source files in bytes of customer project context sent for unit test generation" + }, + { + "name": "userEnteredPromptMessage", + "type": "boolean", + "description": "True if user enter prompt message as input else false" + }, { "name": "userId", "type": "string", @@ -2214,6 +2309,175 @@ } ] }, + { + "name": "amazonq_unitTestGeneration", + "description": "Client side metrics of AmazonQ Unit Test Generation", + "metadata": [ + { + "type": "credentialStartUrl", + "required": false + }, + { + "type": "cwsprChatProgrammingLanguage" + }, + { + "type": "supportedLanguage" + }, + { + "type": "userEnteredPromptMessage" + }, + { + "type": "testGenerationJobGroupName", + "required": false + }, + { + "type": "linesOfCodeAccepted", + "required": false + }, + { + "type": "linesOfCodeGenerated", + "required": false + }, + { + "type": "charsOfCodeAccepted", + "required": false + }, + { + "type": "charsOfCodeGenerated", + "required": false + }, + { + "type": "numberOfUnitTestCasesAccepted", + "required": false + }, + { + "type": "numberOfUnitTestCasesGenerated", + "required": false + }, + { + "type": "numberOfBuildExecuted", + "required": false + }, + { + "type": "numberOfBuildFailed", + "required": false + }, + { + "type": "numberOfBuildPassed", + "required": false + } + ] + }, + { + "name": "amazonq_utg_generateTests", + "description": "Client side invocation of the AmazonQ Unit Test Generation", + "metadata": [ + { + "type": "artifactsUploadDuration", + "required": false + }, + { + "type": "charsOfCodeGenerated", + "required": false + }, + { + "type": "charsOfCodeAccepted", + "required": false + }, + { + "type": "credentialStartUrl", + "required": false + }, + { + "type": "cwsprChatProgrammingLanguage" + }, + { + "type": "latencyOfGeneratingTests", + "required": false + }, + { + "type": "linesOfCodeAccepted", + "required": false + }, + { + "type": "linesOfCodeGenerated", + "required": false + }, + { + "type": "numberOfUnitTestCasesAccepted", + "required": false + }, + { + "type": "numberOfUnitTestCasesGenerated", + "required": false + }, + { + "type": "source", + "required": false + }, + { + "type": "supportedLanguage" + }, + { + "type": "testGenerationJobGroupName", + "required": false + }, + { + "type": "testGenerationJobId", + "required": false + }, + { + "type": "userEnteredPromptMessage" + }, + { + "type": "unitTestGenerationBuildPayloadBytes", + "required": false + }, + { + "type": "unitTestGenerationBuildZipFileBytes", + "required": false + } + ] + }, + { + "name": "amazonq_utg_buildLoop", + "description": "Client side invocation of the AmazonQ Unit Test Generation build loop", + "metadata": [ + { + "type": "buildStatus", + "required": false + }, + { + "type": "credentialStartUrl", + "required": false + }, + { + "type": "cwsprChatProgrammingLanguage" + }, + { + "type": "latencyOfClientSideBuild", + "required": false + }, + { + "type": "source", + "required": false + }, + { + "type": "supportedLanguage" + }, + { + "type": "testGenerationJobGroupName", + "required": false + }, + { + "type": "testGenerationJobId", + "required": false + }, + { + "type": "userEnteredPromptMessage" + } + ] + }, { "name": "amazonq_viewChatPanel", "description": "Captures if Q chat panel is successfully viewed or not", @@ -6997,6 +7261,10 @@ "metadata": [ { "type": "elementId" + }, + { + "type": "step", + "required": false } ] }, From e0452fc2016bf9bb6be4c5be8197d3f0cd25adfe Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:23:04 -0800 Subject: [PATCH 02/14] lint errors --- telemetry/definitions/commonDefinitions.json | 106 +++++++++---------- 1 file changed, 53 insertions(+), 53 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index 38fa2a71..44536503 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -2314,21 +2314,19 @@ "description": "Client side metrics of AmazonQ Unit Test Generation", "metadata": [ { - "type": "credentialStartUrl", + "type": "charsOfCodeAccepted", "required": false }, { - "type": "cwsprChatProgrammingLanguage" + "type": "charsOfCodeGenerated", + "required": false }, { - "type": "supportedLanguage" + "type": "credentialStartUrl", + "required": false }, { - "type": "userEnteredPromptMessage" - }, - { - "type": "testGenerationJobGroupName", - "required": false + "type": "cwsprChatProgrammingLanguage" }, { "type": "linesOfCodeAccepted", @@ -2339,49 +2337,43 @@ "required": false }, { - "type": "charsOfCodeAccepted", + "type": "numberOfUnitTestCasesAccepted", "required": false }, { - "type": "charsOfCodeGenerated", + "type": "numberOfUnitTestCasesGenerated", "required": false }, { - "type": "numberOfUnitTestCasesAccepted", + "type": "numberOfBuildExecuted", "required": false }, { - "type": "numberOfUnitTestCasesGenerated", + "type": "numberOfBuildFailed", "required": false }, { - "type": "numberOfBuildExecuted", - "required": false + "type": "supportedLanguage" }, { - "type": "numberOfBuildFailed", + "type": "testGenerationJobGroupName", "required": false }, { "type": "numberOfBuildPassed", "required": false + }, + { + "type": "userEnteredPromptMessage" } ] }, { - "name": "amazonq_utg_generateTests", - "description": "Client side invocation of the AmazonQ Unit Test Generation", + "name": "amazonq_utg_buildLoop", + "description": "Client side invocation of the AmazonQ Unit Test Generation build loop", "metadata": [ { - "type": "artifactsUploadDuration", - "required": false - }, - { - "type": "charsOfCodeGenerated", - "required": false - }, - { - "type": "charsOfCodeAccepted", + "type": "buildStatus", "required": false }, { @@ -2392,70 +2384,70 @@ "type": "cwsprChatProgrammingLanguage" }, { - "type": "latencyOfGeneratingTests", + "type": "latencyOfClientSideBuild", "required": false }, { - "type": "linesOfCodeAccepted", + "type": "source", "required": false }, { - "type": "linesOfCodeGenerated", - "required": false + "type": "supportedLanguage" }, { - "type": "numberOfUnitTestCasesAccepted", + "type": "testGenerationJobGroupName", "required": false }, { - "type": "numberOfUnitTestCasesGenerated", + "type": "testGenerationJobId", "required": false }, { - "type": "source", + "type": "userEnteredPromptMessage" + } + ] + }, + { + "name": "amazonq_utg_generateTests", + "description": "Client side invocation of the AmazonQ Unit Test Generation", + "metadata": [ + { + "type": "artifactsUploadDuration", "required": false }, { - "type": "supportedLanguage" + "type": "charsOfCodeAccepted", + "required": false }, { - "type": "testGenerationJobGroupName", + "type": "charsOfCodeGenerated", "required": false }, { - "type": "testGenerationJobId", + "type": "credentialStartUrl", "required": false }, { - "type": "userEnteredPromptMessage" + "type": "cwsprChatProgrammingLanguage" }, { - "type": "unitTestGenerationBuildPayloadBytes", + "type": "latencyOfGeneratingTests", "required": false }, { - "type": "unitTestGenerationBuildZipFileBytes", - "required": false - } - ] - }, - { - "name": "amazonq_utg_buildLoop", - "description": "Client side invocation of the AmazonQ Unit Test Generation build loop", - "metadata": [ - { - "type": "buildStatus", + "type": "linesOfCodeAccepted", "required": false }, { - "type": "credentialStartUrl", + "type": "linesOfCodeGenerated", "required": false }, { - "type": "cwsprChatProgrammingLanguage" + "type": "numberOfUnitTestCasesAccepted", + "required": false }, { - "type": "latencyOfClientSideBuild", + "type": "numberOfUnitTestCasesGenerated", "required": false }, { @@ -2470,11 +2462,19 @@ "required": false }, { - "type": "testGenerationJobId", + "type": "testGenerationJobId", "required": false }, { "type": "userEnteredPromptMessage" + }, + { + "type": "unitTestGenerationBuildPayloadBytes", + "required": false + }, + { + "type": "unitTestGenerationBuildZipFileBytes", + "required": false } ] }, From dddb602218c5b113546f8b714d59a3f30a077f9f Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:25:14 -0800 Subject: [PATCH 03/14] lint errors --- telemetry/definitions/commonDefinitions.json | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index 44536503..26ab98d2 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -209,6 +209,16 @@ "type": "boolean", "description": "Boolean value of whether or not a Cfn parameter file is provided." }, + { + "name": "charsOfCodeAccepted", + "type": "int", + "description": "Number of characters of code accepted" + }, + { + "name": "charsOfCodeGenerated", + "type": "int", + "description": "Number of characters of code generated" + }, { "name": "checkType", "type": "string", @@ -1447,16 +1457,6 @@ "type": "int", "description": "Number of lines of code accepted" }, - { - "name": "charsOfCodeGenerated", - "type": "int", - "description": "Number of characters of code generated" - }, - { - "name": "charsOfCodeAccepted", - "type": "int", - "description": "Number of characters of code accepted" - }, { "name": "loadFileTime", "type": "int", From 23f865383ecf04ec98ab3d2cad28c03c8f729f05 Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:27:05 -0800 Subject: [PATCH 04/14] lint errors --- telemetry/definitions/commonDefinitions.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index 26ab98d2..a59c1336 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -2337,19 +2337,19 @@ "required": false }, { - "type": "numberOfUnitTestCasesAccepted", + "type": "numberOfBuildExecuted", "required": false }, { - "type": "numberOfUnitTestCasesGenerated", + "type": "numberOfBuildFailed", "required": false }, { - "type": "numberOfBuildExecuted", + "type": "numberOfUnitTestCasesAccepted", "required": false }, { - "type": "numberOfBuildFailed", + "type": "numberOfUnitTestCasesGenerated", "required": false }, { From 027ad72133c1615374dabe01d3052cecd176ab84 Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:34:48 -0800 Subject: [PATCH 05/14] lint errors --- telemetry/definitions/commonDefinitions.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index a59c1336..4ea6cf10 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -1735,6 +1735,11 @@ "type": "string", "description": "Date/time that an SSO client registration expires." }, + { + "name": "step", + "type": "string", + "description": "Indicates the stage at which a user interface click action was performed." + }, { "name": "successCount", "type": "int", From 44dfd00537b9822860fb4317434a52b1a4ee4240 Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:39:00 -0800 Subject: [PATCH 06/14] lint errors --- telemetry/definitions/commonDefinitions.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index 4ea6cf10..be2d3418 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -2349,6 +2349,10 @@ "type": "numberOfBuildFailed", "required": false }, + { + "type": "numberOfBuildPassed", + "required": false + }, { "type": "numberOfUnitTestCasesAccepted", "required": false @@ -2364,10 +2368,6 @@ "type": "testGenerationJobGroupName", "required": false }, - { - "type": "numberOfBuildPassed", - "required": false - }, { "type": "userEnteredPromptMessage" } @@ -2470,9 +2470,6 @@ "type": "testGenerationJobId", "required": false }, - { - "type": "userEnteredPromptMessage" - }, { "type": "unitTestGenerationBuildPayloadBytes", "required": false @@ -2480,6 +2477,9 @@ { "type": "unitTestGenerationBuildZipFileBytes", "required": false + }, + { + "type": "userEnteredPromptMessage" } ] }, From ccd1f7065c5cf22ee97a73d737e00da8e3880933 Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:40:25 -0800 Subject: [PATCH 07/14] lint errors --- telemetry/definitions/commonDefinitions.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index be2d3418..82afdedd 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -1432,6 +1432,11 @@ ], "description": "The Lambda Package type of the function" }, + { + "name": "language", + "type": "string", + "description": "Language used for the project." + }, { "name": "latencyOfClientSideBuild", "type": "int", @@ -1442,11 +1447,6 @@ "type": "int", "description": "Time from start to end of Generating unit tests" }, - { - "name": "language", - "type": "string", - "description": "Language used for the project." - }, { "name": "linesOfCodeGenerated", "type": "int", From e592cedc39e27fadbdea6a9fa150fc4a45f4c343 Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:41:37 -0800 Subject: [PATCH 08/14] lint errors --- telemetry/definitions/commonDefinitions.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index 82afdedd..f54a9122 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -1448,14 +1448,14 @@ "description": "Time from start to end of Generating unit tests" }, { - "name": "linesOfCodeGenerated", + "name": "linesOfCodeAccepted", "type": "int", - "description": "Number of lines of code generated" + "description": "Number of lines of code accepted" }, { - "name": "linesOfCodeAccepted", + "name": "linesOfCodeGenerated", "type": "int", - "description": "Number of lines of code accepted" + "description": "Number of lines of code generated" }, { "name": "loadFileTime", From 1f192b42755363c7d03993070e0ce90ff230a8bd Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:42:43 -0800 Subject: [PATCH 09/14] lint errors --- telemetry/definitions/commonDefinitions.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index f54a9122..d7775b6a 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -1513,14 +1513,14 @@ "description": "Number of build succeeded in unit test generation build loop" }, { - "name": "numberOfUnitTestCasesGenerated", + "name": "numberOfUnitTestCasesAccepted", "type": "int", - "description": "Number of unit test cases generated" + "description": "Number of unit test cases accepted" }, { - "name": "numberOfUnitTestCasesAccepted", + "name": "numberOfUnitTestCasesGenerated", "type": "int", - "description": "Number of unit test cases accepted" + "description": "Number of unit test cases generated" }, { "name": "oldVersion", From 6c71a1ac4c2888db39edd2cdf433db276f9e37d6 Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Sat, 9 Nov 2024 16:47:24 -0800 Subject: [PATCH 10/14] lint errors --- telemetry/definitions/commonDefinitions.json | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index d7775b6a..cb2478fc 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -1802,6 +1802,16 @@ "type": "string", "description": "Unique identifier for the trace (a set of events) this metric belongs to" }, + { + "name": "unitTestGenerationBuildPayloadBytes", + "type": "int", + "description": "The uncompressed payload size in bytes of the source files in customer project context sent for unit test generation" + }, + { + "name": "unitTestGenerationBuildZipFileBytes", + "type": "int", + "description": "The compressed payload size of source files in bytes of customer project context sent for unit test generation" + }, { "name": "update", "type": "boolean", @@ -1817,16 +1827,6 @@ "type": "string", "description": "User selection from a predefined menu (not user-provided input). See also `action`." }, - { - "name": "unitTestGenerationBuildPayloadBytes", - "type": "int", - "description": "The uncompressed payload size in bytes of the source files in customer project context sent for unit test generation" - }, - { - "name": "unitTestGenerationBuildZipFileBytes", - "type": "int", - "description": "The compressed payload size of source files in bytes of customer project context sent for unit test generation" - }, { "name": "userEnteredPromptMessage", "type": "boolean", From f5144009dd1d270f61c10a2978e9914b40c3d0f8 Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Mon, 11 Nov 2024 14:27:25 -0800 Subject: [PATCH 11/14] Addressing comments --- telemetry/definitions/commonDefinitions.json | 94 ++++++++------------ 1 file changed, 37 insertions(+), 57 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index cb2478fc..41b1996b 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -1,5 +1,10 @@ { "types": [ + { + "name": "acceptedCount", + "type": "int", + "description": "The number of accepted cases" + }, { "name": "action", "type": "string", @@ -178,16 +183,6 @@ "type": "int", "description": "The amount of time required for the build to complete (in seconds)." }, - { - "name": "buildStatus", - "type": "string", - "allowedValues": [ - "SUCCESS", - "FAILED", - "CANCELLED" - ], - "description": "The amount of time required for the build to complete (in seconds)." - }, { "name": "buildSystemVersion", "type": "string", @@ -1227,6 +1222,11 @@ "type": "string", "description": "The name of the EventBridge Schema used in the operation" }, + { + "name": "executedCount", + "type": "int", + "description": "The number of executed operations" + }, { "name": "experimentId", "type": "string", @@ -1293,6 +1293,11 @@ "type": "string", "description": "Application framework being used" }, + { + "name": "generatedCount", + "type": "int", + "description": "The number of generated cases" + }, { "name": "generateFailure", "type": "string", @@ -1497,31 +1502,6 @@ "type": "int", "description": "Number of generations before the user accepted or rejected" }, - { - "name": "numberOfBuildExecuted", - "type": "int", - "description": "Number of build executed in unit test generation build loop" - }, - { - "name": "numberOfBuildFailed", - "type": "int", - "description": "Number of build failures in unit test generation build loop" - }, - { - "name": "numberOfBuildPassed", - "type": "int", - "description": "Number of build succeeded in unit test generation build loop" - }, - { - "name": "numberOfUnitTestCasesAccepted", - "type": "int", - "description": "Number of unit test cases accepted" - }, - { - "name": "numberOfUnitTestCasesGenerated", - "type": "int", - "description": "Number of unit test cases generated" - }, { "name": "oldVersion", "type": "string", @@ -2318,6 +2298,10 @@ "name": "amazonq_unitTestGeneration", "description": "Client side metrics of AmazonQ Unit Test Generation", "metadata": [ + { + "type": "acceptedCount", + "required": false + }, { "type": "charsOfCodeAccepted", "required": false @@ -2334,31 +2318,27 @@ "type": "cwsprChatProgrammingLanguage" }, { - "type": "linesOfCodeAccepted", - "required": false - }, - { - "type": "linesOfCodeGenerated", + "type": "executedCount", "required": false }, { - "type": "numberOfBuildExecuted", + "type": "failedCount", "required": false }, { - "type": "numberOfBuildFailed", + "type": "generatedCount", "required": false }, { - "type": "numberOfBuildPassed", + "type": "linesOfCodeAccepted", "required": false }, { - "type": "numberOfUnitTestCasesAccepted", + "type": "linesOfCodeGenerated", "required": false }, { - "type": "numberOfUnitTestCasesGenerated", + "type": "successCount", "required": false }, { @@ -2377,10 +2357,6 @@ "name": "amazonq_utg_buildLoop", "description": "Client side invocation of the AmazonQ Unit Test Generation build loop", "metadata": [ - { - "type": "buildStatus", - "required": false - }, { "type": "credentialStartUrl", "required": false @@ -2392,6 +2368,10 @@ "type": "latencyOfClientSideBuild", "required": false }, + { + "type": "result", + "required": false + }, { "type": "source", "required": false @@ -2416,6 +2396,10 @@ "name": "amazonq_utg_generateTests", "description": "Client side invocation of the AmazonQ Unit Test Generation", "metadata": [ + { + "type": "acceptedCount", + "required": false + }, { "type": "artifactsUploadDuration", "required": false @@ -2436,23 +2420,19 @@ "type": "cwsprChatProgrammingLanguage" }, { - "type": "latencyOfGeneratingTests", + "type": "generatedCount", "required": false }, { - "type": "linesOfCodeAccepted", - "required": false - }, - { - "type": "linesOfCodeGenerated", + "type": "latencyOfGeneratingTests", "required": false }, { - "type": "numberOfUnitTestCasesAccepted", + "type": "linesOfCodeAccepted", "required": false }, { - "type": "numberOfUnitTestCasesGenerated", + "type": "linesOfCodeGenerated", "required": false }, { From 050008d0e26ece1bae890feab54347e42035431b Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Tue, 12 Nov 2024 10:59:35 -0800 Subject: [PATCH 12/14] Addressing comments --- telemetry/definitions/commonDefinitions.json | 110 ++++++++----------- 1 file changed, 45 insertions(+), 65 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index 41b1996b..03e24bd2 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -183,6 +183,16 @@ "type": "int", "description": "The amount of time required for the build to complete (in seconds)." }, + { + "name": "buildPayloadBytes", + "type": "int", + "description": "The uncompressed payload size in bytes of the source files in customer project context" + }, + { + "name": "buildZipFileBytes", + "type": "int", + "description": "The compressed payload size of source files in bytes of customer project context sent" + }, { "name": "buildSystemVersion", "type": "string", @@ -1452,16 +1462,6 @@ "type": "int", "description": "Time from start to end of Generating unit tests" }, - { - "name": "linesOfCodeAccepted", - "type": "int", - "description": "Number of lines of code accepted" - }, - { - "name": "linesOfCodeGenerated", - "type": "int", - "description": "Number of lines of code generated" - }, { "name": "loadFileTime", "type": "int", @@ -1726,7 +1726,7 @@ "description": "The number of successful operations" }, { - "name": "supportedLanguage", + "name": "isSupportedLanguage", "type": "boolean", "description": "supported language" }, @@ -1749,16 +1749,6 @@ "type": "string", "description": "Generic name of a template" }, - { - "name": "testGenerationJobGroupName", - "type": "string", - "description": "Unit test generation job group name" - }, - { - "name": "testGenerationJobId", - "type": "string", - "description": "Unit test generation job id" - }, { "name": "toolId", "type": "string", @@ -1782,16 +1772,6 @@ "type": "string", "description": "Unique identifier for the trace (a set of events) this metric belongs to" }, - { - "name": "unitTestGenerationBuildPayloadBytes", - "type": "int", - "description": "The uncompressed payload size in bytes of the source files in customer project context sent for unit test generation" - }, - { - "name": "unitTestGenerationBuildZipFileBytes", - "type": "int", - "description": "The compressed payload size of source files in bytes of customer project context sent for unit test generation" - }, { "name": "update", "type": "boolean", @@ -2302,6 +2282,10 @@ "type": "acceptedCount", "required": false }, + { + "type": "acceptedLinesCount", + "required": false + }, { "type": "charsOfCodeAccepted", "required": false @@ -2330,22 +2314,18 @@ "required": false }, { - "type": "linesOfCodeAccepted", + "type": "generatedLinesCount", "required": false }, { - "type": "linesOfCodeGenerated", - "required": false + "type": "isSupportedLanguage" }, { - "type": "successCount", + "type": "jobGroup", "required": false }, { - "type": "supportedLanguage" - }, - { - "type": "testGenerationJobGroupName", + "type": "successCount", "required": false }, { @@ -2357,6 +2337,10 @@ "name": "amazonq_utg_buildLoop", "description": "Client side invocation of the AmazonQ Unit Test Generation build loop", "metadata": [ + { + "type": "codewhispererEndToEndLatency", + "required": false + }, { "type": "credentialStartUrl", "required": false @@ -2365,26 +2349,22 @@ "type": "cwsprChatProgrammingLanguage" }, { - "type": "latencyOfClientSideBuild", - "required": false + "type": "isSupportedLanguage" }, { - "type": "result", + "type": "jobGroup", "required": false }, { - "type": "source", + "type": "jobId", "required": false }, { - "type": "supportedLanguage" - }, - { - "type": "testGenerationJobGroupName", + "type": "result", "required": false }, { - "type": "testGenerationJobId", + "type": "source", "required": false }, { @@ -2401,61 +2381,61 @@ "required": false }, { - "type": "artifactsUploadDuration", + "type": "acceptedLinesCount", "required": false }, { - "type": "charsOfCodeAccepted", + "type": "artifactsUploadDuration", "required": false }, { - "type": "charsOfCodeGenerated", + "type": "buildPayloadBytes", "required": false }, { - "type": "credentialStartUrl", + "type": "buildZipFileBytes", "required": false }, { - "type": "cwsprChatProgrammingLanguage" + "type": "charsOfCodeAccepted", + "required": false }, { - "type": "generatedCount", + "type": "charsOfCodeGenerated", "required": false }, { - "type": "latencyOfGeneratingTests", + "type": "codewhispererEndToEndLatency", "required": false }, { - "type": "linesOfCodeAccepted", + "type": "credentialStartUrl", "required": false }, { - "type": "linesOfCodeGenerated", - "required": false + "type": "cwsprChatProgrammingLanguage" }, { - "type": "source", + "type": "generatedCount", "required": false }, { - "type": "supportedLanguage" + "type": "generatedLinesCount", + "required": false }, { - "type": "testGenerationJobGroupName", - "required": false + "type": "isSupportedLanguage" }, { - "type": "testGenerationJobId", + "type": "jobGroup", "required": false }, { - "type": "unitTestGenerationBuildPayloadBytes", + "type": "jobId", "required": false }, { - "type": "unitTestGenerationBuildZipFileBytes", + "type": "source", "required": false }, { From 758dd96debfd2b6001b648c61c324fcf7af0c65b Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Tue, 12 Nov 2024 11:24:12 -0800 Subject: [PATCH 13/14] Addressing commenrs --- telemetry/definitions/commonDefinitions.json | 53 +++++++------------- 1 file changed, 19 insertions(+), 34 deletions(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index 03e24bd2..b0409063 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -214,16 +214,6 @@ "type": "boolean", "description": "Boolean value of whether or not a Cfn parameter file is provided." }, - { - "name": "charsOfCodeAccepted", - "type": "int", - "description": "Number of characters of code accepted" - }, - { - "name": "charsOfCodeGenerated", - "type": "int", - "description": "Number of characters of code generated" - }, { "name": "checkType", "type": "string", @@ -1303,6 +1293,11 @@ "type": "string", "description": "Application framework being used" }, + { + "name": "generatedCharactersCount", + "type": "int", + "description": "Number of characters of code generated" + }, { "name": "generatedCount", "type": "int", @@ -1452,16 +1447,6 @@ "type": "string", "description": "Language used for the project." }, - { - "name": "latencyOfClientSideBuild", - "type": "int", - "description": "Time from start to end of Client-side build." - }, - { - "name": "latencyOfGeneratingTests", - "type": "int", - "description": "Time from start to end of Generating unit tests" - }, { "name": "loadFileTime", "type": "int", @@ -2283,15 +2268,11 @@ "required": false }, { - "type": "acceptedLinesCount", - "required": false - }, - { - "type": "charsOfCodeAccepted", + "type": "cwsprChatAcceptedCharactersLength", "required": false }, { - "type": "charsOfCodeGenerated", + "type": "cwsprChatAcceptedNumberOfLines", "required": false }, { @@ -2309,6 +2290,10 @@ "type": "failedCount", "required": false }, + { + "type": "generatedCharactersCount", + "required": false + }, { "type": "generatedCount", "required": false @@ -2380,10 +2365,6 @@ "type": "acceptedCount", "required": false }, - { - "type": "acceptedLinesCount", - "required": false - }, { "type": "artifactsUploadDuration", "required": false @@ -2397,24 +2378,28 @@ "required": false }, { - "type": "charsOfCodeAccepted", + "type": "codewhispererEndToEndLatency", "required": false }, { - "type": "charsOfCodeGenerated", + "type": "credentialStartUrl", "required": false }, { - "type": "codewhispererEndToEndLatency", + "type": "cwsprChatAcceptedCharactersLength", "required": false }, { - "type": "credentialStartUrl", + "type": "cwsprChatAcceptedNumberOfLines", "required": false }, { "type": "cwsprChatProgrammingLanguage" }, + { + "type": "generatedCharactersCount", + "required": false + }, { "type": "generatedCount", "required": false From 21c835e9dedd279d4b1035f3e4144a3fd72f2b4a Mon Sep 17 00:00:00 2001 From: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Date: Tue, 12 Nov 2024 11:24:12 -0800 Subject: [PATCH 14/14] Addressing commenrs --- telemetry/definitions/commonDefinitions.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json index b0409063..8d2ce546 100644 --- a/telemetry/definitions/commonDefinitions.json +++ b/telemetry/definitions/commonDefinitions.json @@ -1713,7 +1713,7 @@ { "name": "isSupportedLanguage", "type": "boolean", - "description": "supported language" + "description": "Indicate if the language is supported" }, { "name": "syncedResources",