telemetry(ec2): add more detailed metric on remote VSCode connection.

[Hweinstock]

Problem

Solution

• Add a connection type for remoteWorkspace for opening VSCode window within instance.
• Commons PR: telemetry: add remoteWorkspace connect type for ec2.  aws-toolkit-common#885
• Add tests for telemetry emitted by the core ec2 functions.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[github-actions]

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

[Hweinstock]

Do I need to wait until next release of https://github.com/aws/aws-toolkit-common for this to not fail?

[justinmk3]

aws/aws-toolkit-common@533415f was released in aws/aws-toolkit-common@49de773 (1.0.273).

So updating the dependency here to 1.0.273 or later should work.

[justinmk3]

linux ci found unhandled promise rejections

rejected promise not handled within 1 second: Error: Node with id testId from polling set not found
rejected promise not handled within 1 second: Error: Node with id testId from polling set not found

ERROR: Test output matched this pattern 3 times:
       "rejected promise not handled"
       This typically indicates a bug. Read https://developer.mozilla.org/docs/Web/JavaScript/Guide/Using_promises#error_handling

[Hweinstock]

Ahhhh, forgot to disable the timer in the new tests. I feel like how I implemented the PollingSet as part of the class is becoming a code smell, with how it makes tests flaky if you aren't careful. Do you see a way to simplify it, and avoid the need the disable the polling whenever testing?

[justinmk3]

if these tests have stubbed the command so that it does nothing useful, then they could all be one it('telemetry') test (note: the describe() is still "general", but just a single it() test is for testing telemetry specifically).

Alternatively, if there are existing tests for these commands, can't those existing tests call assertTelemetry ?

[Hweinstock]

The high-level commands are simply wrappers around the logic that is tested in https://github.com/aws/aws-toolkit-vscode/blob/142761e268dd48687d0f696f6ded22819c74ffc7/packages/core/src/test/awsService/ec2/model.test.ts. The only difference at this level is the prompting logic (tested in https://github.com/aws/aws-toolkit-vscode/blob/142761e268dd48687d0f696f6ded22819c74ffc7/packages/core/src/test/awsService/ec2/prompter.test.ts) and telemetry (tested here). It doesn't seem to me to make sense to test any E2E aspects of the code beyond telemetry here.