Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for Macie ListFindings #333

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

mikaylaedwards
Copy link
Contributor

Description

Adding an example for Macie ListFindings. This example shows how to call the Macie ListFindings API with FindingCriteria to filter for Findings Ids that match the criteria.

Motivation and Context

This demonstrates how customers can specify FindingCriteria when calling Macie ListFindings API.

Testing

Tested the code sample using Powershell SDK.

Does not modify the code base.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

We require a second engineer to validate the PR before merging

  • My code builds in Gamma and passes backward compatibility validation (required)
  • My code follows the code style of this project
  • [x ] My change requires a change to the documentation
  • I have updated the documentation accordingly
  • [x ] I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

New/existing dependencies impact assessment, if applicable

Note to reviewers: Please follow runbook to update the internal open source attribution tool

License

  • [x ] I confirm that this pull request can be released under the Apache 2 license

@jnunn-aws jnunn-aws assigned afroz429 and jnunn-aws and unassigned afroz429 and jnunn-aws Aug 25, 2023
@jnunn-aws jnunn-aws requested review from afroz429, jnunn-aws and peterrsongg and removed request for afroz429 August 25, 2023 17:32
Copy link
Contributor

@peterrsongg peterrsongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the doc generator locally to ensure example is being generated correctly and reviewed the example. Approving

@peterrsongg peterrsongg merged commit cdac4da into aws:master Aug 30, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants