omit URL's password when stringifying URL for segment name #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some unit tests for this? |
|
I've added TestRoundTripWithBasicAuth unit test. |
atshaw43
suggested changes
Oct 23, 2023
|
I've updated the pull request. Thanks for the response. |
atshaw43
approved these changes
Oct 24, 2023
|
You will need to rebase with the upstream to merge this. |
aloababa
force-pushed
the
strip_password
branch
from
a8862b5
to
26f2918
Compare
|
I rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #421
Description of changes:
Stripping basic auth password from url to avoid leak in xray traces.