Changing sample-app go.mod redirection #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The sample-app does not work out of the box because the go.mod redirection points to the wrong folder.
Description of changes:
Change the redirection to 2 folders up instead. This causes an issue with EB running with Go. So we change it back for the GitHub workflows.
Other option tried:
I tried changing the folder structure of deploy.zip to get this to work without changing the text of go.mod, but this does not seem possible given the limitations of EB. This would have been the preferred option to me because I find editing code/config to to test to be higher maintenance. However, application.go must be at the working directory level. This is hard coded as a part of EB. And it is awkward to try to place the aws-xray-sdk-go folder two levels up.
https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/go-environment.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.