Skip to content

Commit

Permalink
chore: stop forcing golang/mock to upgrade for make test (#2448)
Browse files Browse the repository at this point in the history
<!-- Provide summary of changes -->
Right now when we are doing `make test` we always automatically upgrade `golang/mock` to the latest. This will break our CI if `golang/mock` introduces any breaking change to our tests. This PR fixes this issue.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
  • Loading branch information
iamhopaul123 authored Jun 11, 2021
1 parent bfcea07 commit 3c238b5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ e2e: build-e2e

.PHONY: tools
tools:
GOBIN=${GOBIN} go get github.com/golang/mock/mockgen
GOBIN=${GOBIN} go get github.com/gobuffalo/packr/v2/packr2
@echo "Installing custom resource dependencies" &&\
cd ${SOURCE_CUSTOM_RESOURCES} && npm ci
Expand All @@ -140,6 +139,7 @@ site-local:

.PHONY: gen-mocks
gen-mocks: tools
GOBIN=${GOBIN} go get github.com/golang/mock/mockgen
# TODO: make this more extensible?
${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/cli/mocks/mock_rg.go -source=./internal/pkg/cli/env_delete.go resourceGetter
${GOBIN}/mockgen -source=./internal/pkg/term/progress/spinner.go -package=mocks -destination=./internal/pkg/term/progress/mocks/mock_spinner.go
Expand Down

0 comments on commit 3c238b5

Please sign in to comment.