Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes hook amd presubmit to use proper env var #405

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Jul 22, 2024

Issue #, if available:

Description of changes:

When I added the arm build I copied the env var from other presubmit jobs. The one we were using is wrong, we changed at one point and never updated these jobs. The actual env var is, FAKE_ARM_BINARIES_FOR_VALIDATION, per https://github.com/aws/eks-anywhere-build-tooling/blob/main/Common.mk#L452. We do not to usually set it because its auto set based on the binary_platforms

The hook build is a bit different because I left the amd build building both binary platforms, because it can, most of the other examples cannot because they are cross compiling use CGO. I left it this way so that checksum updates is a bit easier. So for this presubmit I am going to set the fake explicitly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaxesn jaxesn merged commit b75e179 into aws:main Jul 22, 2024
3 of 4 checks passed
@eks-distro-bot
Copy link
Collaborator

@jaxesn: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key containerd-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/containerd-presubmits.yaml
  • key hook-presubmit.yaml using file jobs/aws/eks-anywhere-build-tooling/hook-presubmit.yaml
  • key runc-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/runc-presubmits.yaml
  • key source-controller-presubmits.yaml using file jobs/aws/eks-anywhere-build-tooling/source-controller-presubmits.yaml

In response to this:

Issue #, if available:

Description of changes:

When I added the arm build I copied the env var from other presubmit jobs. The one we were using is wrong, we changed at one point and never updated these jobs. The actual env var is, FAKE_ARM_BINARIES_FOR_VALIDATION, per https://github.com/aws/eks-anywhere-build-tooling/blob/main/Common.mk#L452. We do not to usually set it because its auto set based on the binary_platforms

The hook build is a bit different because I left the amd build building both binary platforms, because it can, most of the other examples cannot because they are cross compiling use CGO. I left it this way so that checksum updates is a bit easier. So for this presubmit I am going to set the fake explicitly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants