fixes hook amd presubmit to use proper env var #405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When I added the arm build I copied the env var from other presubmit jobs. The one we were using is wrong, we changed at one point and never updated these jobs. The actual env var is,
FAKE_ARM_BINARIES_FOR_VALIDATION
, per https://github.com/aws/eks-anywhere-build-tooling/blob/main/Common.mk#L452. We do not to usually set it because its auto set based on thebinary_platforms
The hook build is a bit different because I left the amd build building both binary platforms, because it can, most of the other examples cannot because they are cross compiling use CGO. I left it this way so that checksum updates is a bit easier. So for this presubmit I am going to set the fake explicitly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.