Skip to content

Commit

Permalink
fix(runtime): excessive latency introduced by sleep (#2298)
Browse files Browse the repository at this point in the history
When recovering from `EAGAIN`, the `@jsii/runtime` recently added a
synchronous sleep for 50 milliseconds. However in large and complex
applications, this can add up to a lot of time, as worst case scenario,
the sleep can occur before and after each call (once on read, once on
write).

This change removes the `sleep` until we come up with a better solution.

Fixes #2284



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
  • Loading branch information
RomainMuller authored Dec 7, 2020
1 parent 9b40f16 commit 1a94b85
Show file tree
Hide file tree
Showing 5 changed files with 133 additions and 116 deletions.
27 changes: 27 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,33 @@
"bug"
]
},
{
"login": "ThomasSteinbach",
"name": "Thomas Steinbach",
"avatar_url": "https://avatars0.githubusercontent.com/u/1683246?v=4",
"profile": "https://github.com/ThomasSteinbach",
"contributions": [
"bug"
]
},
{
"login": "Ophirr33",
"name": "Ty Coghlan",
"avatar_url": "https://avatars2.githubusercontent.com/u/15920577?v=4",
"profile": "https://ty.coghlan.dev/",
"contributions": [
"bug"
]
},
{
"login": "slotnick",
"name": "Dave Slotnick",
"avatar_url": "https://avatars3.githubusercontent.com/u/918175?v=4",
"profile": "https://github.com/slotnick",
"contributions": [
"bug"
]
},
{
"login": "majasb",
"name": "Maja S Bratseth",
Expand Down
Loading

0 comments on commit 1a94b85

Please sign in to comment.