Keep glob back, we can't upgrade it without our minimum Node

aws · Jul 26, 2024 · 3c10603 · 3c10603
1 parent 34cea56
commit 3c10603
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 72 deletions.
diff --git a/.github/workflows/yarn-upgrade.yml b/.github/workflows/yarn-upgrade.yml
@@ -87,8 +87,10 @@ jobs:
             --filter=typescript
 
           # Upgrade all other dependencies (devDependencies) to the latest
+          # Exclude:
+          # - glob, because newer version don't support Node 18
           lerna exec --parallel ncu -- --upgrade --target=latest                                    \
-            --reject='@types/inquirer,@types/node,typescript,@types/fs-extra,@types/yargs,${{ steps.production-dependencies.outputs.list }},${{ steps.monorepo-packages.outputs.list }}'
+            --reject='@types/inquirer,@types/node,typescript,@types/fs-extra,@types/yargs,glob,${{ steps.production-dependencies.outputs.list }},${{ steps.monorepo-packages.outputs.list }}'
 
       # This will ensure the current lockfile is up-to-date with the dependency specifications (necessary for "yarn update" to run)
       - name: Run "yarn install"

diff --git a/packages/@jsii/benchmarks/package.json b/packages/@jsii/benchmarks/package.json
@@ -14,7 +14,7 @@
   },
   "devDependencies": {
     "@types/glob": "^8.1.0",
-    "glob": "^11.0.0"
+    "glob": "^10.3.12"
   },
   "scripts": {
     "build": "yarn --silent tsc --build && npm run lint",

diff --git a/yarn.lock b/yarn.lock