chore(release): 1.29.0 (#2806)

See [CHANGELOG](https://github.com/aws/jsii/blob/bump/1.29.0/CHANGELOG.md)
aws · Apr 21, 2021 · 41df200 · 41df200
2 parents 1801f4f + 5886164
commit 41df200
Show file tree

Hide file tree

Showing 28 changed files with 348 additions and 308 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,18 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [1.29.0](https://github.com/aws/jsii/compare/v1.28.0...v1.29.0) (2021-04-21)
+
+
+### Features
+
+* **superchain:** add github cli ([#2803](https://github.com/aws/jsii/issues/2803)) ([23f3582](https://github.com/aws/jsii/commit/23f3582fafaee2b7a64c92d6d426783b31f5aea4))
+
+
+### Bug Fixes
+
+* **go:** panic on callback: using *<interface> as <interface> ([#2797](https://github.com/aws/jsii/issues/2797)) ([e5a40d8](https://github.com/aws/jsii/commit/e5a40d8ec59b8dd92cd19274154208bbef099637)), closes [#2793](https://github.com/aws/jsii/issues/2793)
+
 ## [1.28.0](https://github.com/aws/jsii/compare/v1.27.1...v1.28.0) (2021-04-13)
 
 

diff --git a/gh-pages/content/specification/6-compliance-report.md b/gh-pages/content/specification/6-compliance-report.md
diff --git a/gh-pages/requirements-dev.txt b/gh-pages/requirements-dev.txt
@@ -1,4 +1,4 @@
 mkdocs~=1.1.2
 mkdocs-awesome-pages-plugin~=2.5.0
-mkdocs-material~=7.1.1
+mkdocs-material~=7.1.2
 mkdocs-git-revision-date-plugin~=0.3.1
diff --git a/lerna.json b/lerna.json
@@ -10,5 +10,5 @@
       "rejectCycles": true
     }
   },
-  "version": "1.28.0"
+  "version": "1.29.0"
 }
diff --git a/package.json b/package.json
@@ -16,11 +16,11 @@
   },
   "devDependencies": {
     "@jest/types": "^26.6.2",
-    "@typescript-eslint/eslint-plugin": "^4.21.0",
-    "@typescript-eslint/parser": "^4.21.0",
+    "@typescript-eslint/eslint-plugin": "^4.22.0",
+    "@typescript-eslint/parser": "^4.22.0",
     "all-contributors-cli": "^6.20.0",
-    "eslint": "^7.23.0",
-    "eslint-config-prettier": "^8.1.0",
+    "eslint": "^7.24.0",
+    "eslint-config-prettier": "^8.2.0",
     "eslint-import-resolver-node": "^0.3.4",
     "eslint-import-resolver-typescript": "^2.4.0",
     "eslint-plugin-import": "^2.22.1",

diff --git a/packages/@jsii/go-runtime-test/project/compliance_test.go b/packages/@jsii/go-runtime-test/project/compliance_test.go
@@ -8,17 +8,15 @@ import (
 	"testing"
 	"time"
 
+	"github.com/aws/jsii-runtime-go"
 	"github.com/aws/jsii/go-runtime-test/internal/addTen"
+	"github.com/aws/jsii/go-runtime-test/internal/bellRinger"
 	"github.com/aws/jsii/go-runtime-test/internal/doNotOverridePrivates"
-
 	"github.com/aws/jsii/go-runtime-test/internal/friendlyRandom"
 	"github.com/aws/jsii/go-runtime-test/internal/overrideAsyncMethods"
 	"github.com/aws/jsii/go-runtime-test/internal/syncOverrides"
 	"github.com/aws/jsii/go-runtime-test/internal/twoOverrides"
 	"github.com/aws/jsii/go-runtime-test/internal/wallClock"
-
-	"github.com/aws/jsii-runtime-go"
-
 	"github.com/aws/jsii/jsii-calc/go/jcb"
 	calc "github.com/aws/jsii/jsii-calc/go/jsiicalc/v3"
 	"github.com/aws/jsii/jsii-calc/go/jsiicalc/v3/composition"
@@ -1632,6 +1630,16 @@ func (suite *ComplianceSuite) TestCollectionOfInterfaces_MapOfStructs() {
 	require.Equal("Hello, I'm String!", *(*m["A"]).RequiredString)
 }
 
+func (suite *ComplianceSuite) TestCallbackParameterIsInterface() {
+	require := suite.Require()
+
+	ringer := bellRinger.New()
+
+	require.True(*calc.ConsumerCanRingBell_StaticImplementedByObjectLiteral(ringer))
+	require.True(*calc.ConsumerCanRingBell_StaticImplementedByPrivateClass(ringer))
+	require.True(*calc.ConsumerCanRingBell_StaticImplementedByPublicClass(ringer))
+}
+
 // required to make `go test` recognize the suite.
 func TestComplianceSuite(t *testing.T) {
 	suite.Run(t, new(ComplianceSuite))

diff --git a/packages/@jsii/go-runtime-test/project/internal/bellRinger/bellRinger.go b/packages/@jsii/go-runtime-test/project/internal/bellRinger/bellRinger.go
@@ -0,0 +1,13 @@
+package bellRinger
+
+import "github.com/aws/jsii/jsii-calc/go/jsiicalc/v3"
+
+func New() jsiicalc.IBellRinger {
+	return &ringer{}
+}
+
+type ringer struct{}
+
+func (r *ringer) YourTurn(bell jsiicalc.IBell) {
+	bell.Ring()
+}
diff --git a/packages/@jsii/go-runtime/jsii-runtime-go/internal/kernel/callbacks.go b/packages/@jsii/go-runtime/jsii-runtime-go/internal/kernel/callbacks.go
@@ -124,7 +124,7 @@ func (c *Client) invoke(method reflect.Value, args []interface{}) (retval reflec
 			callArgs[i] = reflect.New(argType)
 		}
 		c.castAndSetToPtr(callArgs[i].Elem(), reflect.ValueOf(arg))
-		if argType.Kind() != reflect.Ptr && argType.Kind() != reflect.Interface {
+		if argType.Kind() != reflect.Ptr {
 			// The result of `reflect.New` is always a pointer, so if the
 			// argument is by-value, we have to de-reference it first.
 			callArgs[i] = callArgs[i].Elem()

diff --git a/packages/@jsii/go-runtime/package.json b/packages/@jsii/go-runtime/package.json
@@ -26,7 +26,7 @@
     "@types/fs-extra": "^8.1.1",
     "@types/node": "^10.17.56",
     "codemaker": "^0.0.0",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "fs-extra": "^9.1.0",
     "jsii-build-tools": "^0.0.0",
     "jsii-calc": "^3.20.120",

diff --git a/packages/@jsii/integ-test/package.json b/packages/@jsii/integ-test/package.json
@@ -32,7 +32,7 @@
     "@types/jest": "^26.0.22",
     "@types/node": "^10.17.56",
     "@types/tar": "^4.0.4",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "prettier": "^2.2.1",
     "typescript": "~3.9.9"
   }

diff --git a/packages/@jsii/kernel/package.json b/packages/@jsii/kernel/package.json
@@ -43,7 +43,7 @@
     "@types/jest-expect-message": "^1.0.3",
     "@types/node": "^10.17.56",
     "@types/tar": "^4.0.4",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jest-expect-message": "^1.0.2",
     "jsii-build-tools": "^0.0.0",

diff --git a/packages/@jsii/python-runtime/setup.py b/packages/@jsii/python-runtime/setup.py
@@ -32,7 +32,7 @@
     install_requires=[
         "attrs~=20.1",
         "cattrs~=1.0.0 ; python_version < '3.7'",
-        "cattrs~=1.4.0 ; python_version >= '3.7'",
+        "cattrs~=1.5.0 ; python_version >= '3.7'",
         "importlib_resources ; python_version < '3.7'",
         "python-dateutil",
         "typing_extensions~=3.7",

diff --git a/packages/@jsii/runtime/package.json b/packages/@jsii/runtime/package.json
@@ -42,15 +42,15 @@
     "@scope/jsii-calc-lib": "^0.0.0",
     "@types/jest": "^26.0.22",
     "@types/node": "^10.17.56",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jsii-build-tools": "^0.0.0",
     "jsii-calc": "^3.20.120",
     "prettier": "^2.2.1",
     "source-map-loader": "^2.0.1",
     "ts-jest": "^26.5.4",
     "typescript": "~3.9.9",
-    "webpack": "^5.30.0",
+    "webpack": "^5.32.0",
     "webpack-cli": "^4.6.0"
   }
 }
diff --git a/packages/@jsii/spec/package.json b/packages/@jsii/spec/package.json
@@ -36,7 +36,7 @@
   "devDependencies": {
     "@types/jest": "^26.0.22",
     "@types/node": "^10.17.56",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jsii-build-tools": "^0.0.0",
     "prettier": "^2.2.1",

diff --git a/packages/codemaker/package.json b/packages/codemaker/package.json
@@ -39,7 +39,7 @@
     "@types/fs-extra": "^8.1.1",
     "@types/jest": "^26.0.22",
     "@types/node": "^10.17.56",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "prettier": "^2.2.1",
     "typescript": "~3.9.9"

diff --git a/packages/jsii-calc/package.json b/packages/jsii-calc/package.json
@@ -52,7 +52,7 @@
   },
   "devDependencies": {
     "@types/node": "^10.17.56",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jsii": "^0.0.0",
     "jsii-build-tools": "^0.0.0",
     "jsii-rosetta": "^0.0.0",

diff --git a/packages/jsii-config/package.json b/packages/jsii-config/package.json
@@ -24,7 +24,7 @@
     "@types/jest-expect-message": "^1.0.3",
     "@types/node": "^10.17.56",
     "@types/yargs": "^16.0.1",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jest-expect-message": "^1.0.2",
     "prettier": "^2.2.1",

diff --git a/packages/jsii-diff/package.json b/packages/jsii-diff/package.json
@@ -47,7 +47,7 @@
     "@types/node": "^10.17.56",
     "@types/tar-fs": "^2.0.0",
     "@types/yargs": "^16.0.1",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jest-expect-message": "^1.0.2",
     "jsii": "^0.0.0",

diff --git a/packages/jsii-pacmak/package.json b/packages/jsii-pacmak/package.json
@@ -62,7 +62,7 @@
     "@types/node": "^10.17.56",
     "@types/semver": "^7.3.4",
     "@types/yargs": "^16.0.1",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jsii": "^0.0.0",
     "jsii-build-tools": "^0.0.0",

diff --git a/packages/jsii-reflect/package.json b/packages/jsii-reflect/package.json
@@ -46,7 +46,7 @@
     "@types/jest": "^26.0.22",
     "@types/node": "^10.17.56",
     "@types/yargs": "^16.0.1",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jsii": "^0.0.0",
     "jsii-build-tools": "^0.0.0",

diff --git a/packages/jsii-rosetta/package.json b/packages/jsii-rosetta/package.json
@@ -22,7 +22,7 @@
     "@types/mock-fs": "^4.13.0",
     "@types/node": "^10.17.56",
     "@types/yargs": "^16.0.1",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jsii": "^0.0.0",
     "jsii-build-tools": "^0.0.0",

diff --git a/packages/jsii/package.json b/packages/jsii/package.json
@@ -57,7 +57,7 @@
     "@types/semver": "^7.3.4",
     "@types/yargs": "^16.0.1",
     "clone": "^2.1.2",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jest-expect-message": "^1.0.2",
     "jsii-build-tools": "^0.0.0",

diff --git a/packages/oo-ascii-tree/package.json b/packages/oo-ascii-tree/package.json
@@ -33,7 +33,7 @@
   "devDependencies": {
     "@types/jest": "^26.0.22",
     "@types/node": "^10.17.56",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "jest": "^26.6.3",
     "jsii-build-tools": "^0.0.0",
     "prettier": "^2.2.1",

diff --git a/superchain/Dockerfile b/superchain/Dockerfile
@@ -19,7 +19,8 @@ ENV LANG="C.UTF-8"
     M2="/usr/local/apache-maven/bin"                                                                                    \
     MAVEN_OPTS="-Xms256m -Xmx512m"                                                                                      \
                                                                                                                         \
-    GOROOT="/usr/local/go"
+    GOROOT="/usr/local/go"                                                                                              \
+    GITHUB_CLI_VERSION="1.9.2"
 
 # Install deltarpm as it can speed up the upgrade processes, and tar as it's needed for installing Maven
 # Also upgrading anything already installed, and adding some common dependencies for included tools
@@ -98,6 +99,11 @@ RUN curl -sSL https://dl.yarnpkg.com/rpm/yarn.repo | tee /etc/yum.repos.d/yarn.r
   && yum -y install yarn                                                                                                \
   && yum clean all && rm -rf /var/cache/yum
 
+# Install GitHub CLI
+RUN curl -sL https://github.com/cli/cli/releases/download/v${GITHUB_CLI_VERSION}/gh_${GITHUB_CLI_VERSION}_linux_amd64.tar.gz | \
+  tar -xzv --strip-components=2 gh_${GITHUB_CLI_VERSION}_linux_amd64/bin/gh                                                    \
+  && mv gh /usr/bin/
+
 # Install some configuration
 COPY ssh_config /root/.ssh/config
 RUN chmod 600 /root/.ssh/config

diff --git a/superchain/README.md b/superchain/README.md
@@ -51,6 +51,7 @@ Tool / Utility | Version
 `rsync`        | `>= 3.1.2`
 `yarn`         | `>= 1.21.1`
 `zip` & `unzip`| `>= 6.0-19`
+`gh`           | `>= 1.9.2`
 
 ## License
 

diff --git a/tools/jsii-compliance/package.json b/tools/jsii-compliance/package.json
@@ -17,7 +17,7 @@
   },
   "devDependencies": {
     "@types/node": "^10.17.56",
-    "eslint": "^7.23.0",
+    "eslint": "^7.24.0",
     "prettier": "^2.2.1",
     "ts-node": "^9.1.1",
     "typescript": "~3.9.9"

diff --git a/tools/jsii-compliance/suite.ts b/tools/jsii-compliance/suite.ts
@@ -31,7 +31,7 @@ export const suite: schema.Suite = {
     {
       name: 'unionProperties',
       description:
-        'Kernal values that accept a union type can be set, and are returned with the concrete type',
+        'Kernel values that accept a union type can be set, and are returned with the concrete type',
     },
     {
       name: 'syncOverrides',
@@ -503,5 +503,9 @@ export const suite: schema.Suite = {
       name: 'testInterfaces',
       description: '',
     },
+    {
+      name: 'callbackParameterIsInterface',
+      description: 'Validates pure interfaces can be passed to callbacks',
+    },
   ],
 };