Skip to content

Commit

Permalink
chore(release): 1.46.0 (#3195)
Browse files Browse the repository at this point in the history
  • Loading branch information
aws-cdk-automation authored Nov 21, 2021
1 parent 61747b6 commit cd08c55
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 1 deletion.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [1.46.0](https://github.com/aws/jsii/compare/v1.45.0...v1.46.0) (2021-11-21)


### Bug Fixes

* **rosetta:** `extract` ignores `--compile` option ([#3193](https://github.com/aws/jsii/issues/3193)) ([639c510](https://github.com/aws/jsii/commit/639c510ba6d07b26bf35d0c8d3c9cdcced6d916a))
* **rosetta:** enum resolution breaks for properties ([#3190](https://github.com/aws/jsii/issues/3190)) ([3b49066](https://github.com/aws/jsii/commit/3b49066e4dd960385709dbdce1d9c1fbfb2f20cf))

## [1.45.0](https://github.com/aws/jsii/compare/v1.44.1...v1.45.0) (2021-11-18)


Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
"rejectCycles": true
}
},
"version": "1.45.0"
"version": "1.46.0"
}
1 change: 1 addition & 0 deletions packages/jsii-rosetta/lib/commands/extract.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export async function extractSnippets(
}

const translatorOptions: RosettaTranslatorOptions = {
includeCompilerDiagnostics: options.includeCompilerDiagnostics,
assemblies: assemblies.map((a) => a.assembly),
};

Expand Down
14 changes: 14 additions & 0 deletions packages/jsii-rosetta/test/commands/extract.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,20 @@ describe('with cache file', () => {
(TARGET_LANGUAGES.java as any).version = oldJavaVersion;
}
});

test('compiler diagnostics property is passed on', async () => {
const translationFunction = jest.fn().mockResolvedValue({ diagnostics: [], translatedSnippets: [] });

await extract.extractSnippets([assembly.moduleDirectory], {
outputFile: path.join(assembly.moduleDirectory, 'dummy.tabl.json'),
validateAssemblies: false,
includeCompilerDiagnostics: true,
translatorFactory: (o) => {
expect(o.includeCompilerDiagnostics).toEqual(true);
return new MockTranslator(o, translationFunction);
},
});
});
});

test('do not ignore example strings', async () => {
Expand Down

0 comments on commit cd08c55

Please sign in to comment.