You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After reviewing some of the java target source code. I can see that a default maven pom and user xml file are created. Additionally, I can see that the mvn command that is executed here:
It appears that there is a maven version enforcer configured to ensure that maven version 3.6 or newer is used. Why not leverage the maven wrapper mvn wrapper:wrapper, to generate a mvnw file, specify the desired / supported maven version, and then execute mvnw as opposed to relying on un-managed, external configurations of the build host?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
After reviewing some of the java target source code. I can see that a default maven pom and user xml file are created. Additionally, I can see that the mvn command that is executed here:
jsii/packages/jsii-pacmak/lib/targets/java.ts
Line 442 in fa1606c
It appears that there is a maven version enforcer configured to ensure that maven version 3.6 or newer is used. Why not leverage the maven wrapper
mvn wrapper:wrapper, to generate a mvnw file, specify the desired / supported maven version, and then executemvnwas opposed to relying on un-managed, external configurations of the build host?Beta Was this translation helpful? Give feedback.
All reactions