Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: #3490: add information provided in comment to docs (jsii = js interop iface) #4188

Conversation

alexanderankin
Copy link

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify
Copy link
Contributor

mergify bot commented Jul 23, 2023

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@alexanderankin alexanderankin changed the title fixes #3490: add information provided in comment to docs (jsii = js interop iface) fix: #3490: add information provided in comment to docs (jsii = js interop iface) Jul 23, 2023
@alexanderankin alexanderankin changed the title fix: #3490: add information provided in comment to docs (jsii = js interop iface) docs: #3490: add information provided in comment to docs (jsii = js interop iface) Jul 23, 2023
Comment on lines +20 to +21
!!! info
`jsii` [stands for](https://github.com/aws/jsii/issues/3490) **J**ava**S**cript **I**nteroperability **I**nterface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not. "jsii" is not an acronym, same as "npm" is not an acronym (https://en.wikipedia.org/wiki/Npm).

MAYBE it used to mean this, but this would be limiting future potential and anchors on current implementation details more than strictly necessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i think the project should have a right to reject an acronym but that is a poor example as npm's acronym expansion is extremely obvious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants