Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(jsii-diff): explain making properties optional #4274

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Sep 21, 2023

This question comes up every other week. Let's make a single place to explain it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rix0rrr rix0rrr requested a review from a team September 21, 2023 12:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 21, 2023
@rix0rrr rix0rrr marked this pull request as draft September 21, 2023 12:59
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the explanation :)

Copy link
Contributor

@otaviomacedo otaviomacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rix0rrr rix0rrr marked this pull request as ready for review September 21, 2023 13:38
@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Sep 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2023

Merging (with squash)...

@mergify mergify bot merged commit 0075121 into main Sep 21, 2023
35 checks passed
@mergify mergify bot deleted the huijbers/jsii-diff-explainer branch September 21, 2023 14:37
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants