feat(pacmak): update Python dependency typeguard to more modern version
#4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwanbolzern
changed the title
|
Dear jsii maintainers, Any chance that we can get this merged soon? Thank you and all the best, |
mrgrain
changed the title
typeguard to more modern version
|
Thanks for raising the PR. This will needs an update to the snapshot tests. |
|
Oh cool, good to see this in progress. Thanks @iwanbolzern. I opened an Issue for this just yesterday, didn't see the PR. This will take more than just upgrading the version. The generated code needs to change. I did some monkey patch experiments. See: #4469 |
|
Have opened a PR that updates the generated code and updates the snapshot tests: #4470 |
|
Thanks @sam-goodwin for looking into this! I'm going to close this PR in favor of yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Python typeguard dependency to reasonable new version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.