Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(superchain): explicitly list supported images #4500

Merged
merged 2 commits into from
May 2, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 1, 2024

There are a lot of image tags in the jsii/superchain image repo. Only a few of which are actively supported.

Previously we attempted to explain the rules and list supported versions of the subcomponents, but that was complicated and missed a few cases.

With this change we are just listing them explicitly.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 1, 2024
@mrgrain mrgrain changed the title chore: update docs chore(superchain): explicitly list supported images May 1, 2024
@mrgrain mrgrain marked this pull request as ready for review May 1, 2024 15:37
Copy link
Contributor

mergify bot commented May 2, 2024

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label May 2, 2024
Copy link
Contributor

mergify bot commented May 2, 2024

Merging (with squash)...

@mergify mergify bot merged commit 5f7783b into main May 2, 2024
41 checks passed
@mergify mergify bot deleted the chore/supported-images branch May 2, 2024 09:43
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants