Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bhavyssh/tot image size report #524

Merged

Conversation

bhavya2109sharma
Copy link
Contributor

Issue #, if available:

Description of changes:

  1. Added functionality : get_image_size function in package_report.py to calculate total Image size of the image with respect to its base image and it will generates report for GPU and CPU configurations.
  2. Added _generate_image_size_report function to print the report in desired format.
  3. Integrated image size reporting into the same function : generate_package_size_report for simplicity of having size reports in same place.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@aws-tianquaw aws-tianquaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested and verified your script locally? Can you attach a sample image size report to the PR?

@bhavya2109sharma bhavya2109sharma merged commit 52b7570 into aws:main Nov 25, 2024
1 check failed
@bhavya2109sharma bhavya2109sharma deleted the bhavyssh/tot_image_size_report branch November 27, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants