Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNS EventSource does not create FIFO queue when topic is FIFO #2259

Closed
singledigit opened this issue Dec 4, 2020 · 2 comments
Closed

SNS EventSource does not create FIFO queue when topic is FIFO #2259

singledigit opened this issue Dec 4, 2020 · 2 comments

Comments

@singledigit
Copy link
Contributor

Description:

When using an SNS event source and the SNS Topic is a FIFO topic, the SqsSubscription: true parameter should cause an SQS FIFO queue to be created.

Steps to reproduce:

  1. Configure a SNS FIFO Topic
  2. Set the event source for the Lambda to the SNS FIFO Topic
  3. set the SqsSubscription: true value
Transform: AWS::Serverless-2016-10-31
Description: SNS Fifo
Globals:
  Function:
    Timeout: 3

Resources:
  MyFifoTopic:
    Type: AWS::SNS::Topic
    Properties: 
      ContentBasedDeduplication: true
      FifoTopic: true
      TopicName: myFifoTopic.fifo
  
  HelloWorldFunction:
    Type: AWS::Serverless::Function
    Properties:
      PackageType: Image
      ImageConfig:
        Command: ["app.lambdaHandler"]
      Events:
        FifoTrigger:
          Type: SNS
          Properties:
            SqsSubscription: true
            Topic: !Ref MyFifoTopic
    Metadata:
      DockerTag: nodejs12.x-v1
      DockerContext: ./hello-world
      Dockerfile: Dockerfile

run sam build && sam deploy

Observed result:

Requested update requires the creation of a new physical resource; hence creating one. Invalid parameter: Invalid parameter: Endpoint Reason: Please use FIFO SQS queue (Service: AmazonSNS; Status Code: 400; Error Code: InvalidParameter; Request ID: ec5c7770-3326-55a5-9c6a-2f33e6db3edf; Proxy: null)                                    


### Expected result:
A SQS FIFO Queue to be created


### Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

1. OS: Cloud9 AL2
2. `sam --version`: 1.13.2

`Add --debug flag to command you are running`
@xazhao
Copy link
Contributor

xazhao commented Dec 6, 2021

It seems like an issue of SAM not SAM CLI. Transferring the issue.

@xazhao xazhao transferred this issue from aws/aws-sam-cli Dec 6, 2021
@ssenchenko ssenchenko added the stage/needs-investigation Requires a deeper investigation label Dec 8, 2021
@GavinZZ
Copy link
Contributor

GavinZZ commented Oct 3, 2023

Hi there, this issue is addressed in #3357. Please expect around 2~3 weeks of deployment time.

@GavinZZ GavinZZ closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants