Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for new appsync GraphQL properties #3666

Closed
vaibhav170 opened this issue Oct 14, 2024 · 3 comments
Closed

support for new appsync GraphQL properties #3666

vaibhav170 opened this issue Oct 14, 2024 · 3 comments
Labels
stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Comments

@vaibhav170
Copy link
Contributor

Hi
We have observed some newly added CloudFormation properties are not supported in SAM yet, can we have support added for them, currently we were mainly interested in introspection, resolver count limit & query depth limit properties to align with our security checks, plan was to create PR for this by referring #3423 but observed other missing properties and its touching some existing complex data types so did not created PR

observed missing properties:

IntrospectionConfig
ResolverCountLimit
QueryDepthLimit
EnvironmentVariables
EnhancedMetricsConfig
MergedApiExecutionRoleArn

EnhancedMetricsConfig for resolver & data source
@vaibhav170 vaibhav170 added the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Oct 14, 2024
@vaibhav170 vaibhav170 mentioned this issue Oct 22, 2024
Merged
5 tasks
@vaibhav170
Copy link
Contributor Author

created PR #3668 to add support for this three simple pass through properties
IntrospectionConfig
ResolverCountLimit
QueryDepthLimit

@vaibhav170
Copy link
Contributor Author

fixed with PR #3668 and it's available to use

@github-actions GitHub Actions
Copy link
Contributor

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vaibhav170