Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add introspection, query & resolver limits properties in appsync graphql api #3668

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

vaibhav170
Copy link
Contributor

@vaibhav170 vaibhav170 commented Oct 22, 2024

Issue #3666

Description of changes

Adding new fields AppSync has added to CFN.
IntrospectionConfig
ResolverCountLimit
QueryDepthLimit

Description of how you validated changes

this three are pass through properties, tested output of bin/add_transform_test.py script by deploying it using cloudformation, working as expected

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vaibhav170
Copy link
Contributor Author

Hi @GavinZZ can you help or give direction on getting this PR reviewed and merged, as we need this attributes support for security compliance

Copy link
Member

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vaibhav170 for the contribution. LGTM

@godwingrs22 godwingrs22 changed the title [ADDED] introspection, query & resolver limits properties in appsync feat: add introspection, query & resolver limits properties in appsync graphql api Oct 29, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, are you able to add an integration test case for these properties to test the deployability?

@vaibhav170
Copy link
Contributor Author

Changes look good, are you able to add an integration test case for these properties to test the deployability?

hi @GavinZZ added integration test for Introspection configuration

@GavinZZ
Copy link
Contributor

GavinZZ commented Oct 30, 2024

Thank you for contributing!

@jfuss jfuss merged commit 03a37fe into aws:develop Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants