Skip to content

Commit

Permalink
align span attribute names with recommended
Browse files Browse the repository at this point in the history
  • Loading branch information
lucix-aws committed Sep 18, 2024
1 parent b1d902b commit 9ac68b5
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -398,14 +398,13 @@ defer endTimer()
decorated := middleware.DecorateHandler(handler, stack)
result, metadata, err = decorated.Handle(ctx, params)
if err != nil {
span.SetProperty("error.go.type", fmt.Sprintf("%T", err))
span.SetProperty("error.go.error", err.Error())
span.SetProperty("exception.type", fmt.Sprintf("%T", err))
span.SetProperty("exception.message", err.Error())
var aerr smithy.APIError
if $errors.As:T(err, &aerr) {
span.SetProperty("error.api.code", aerr.ErrorCode())
span.SetProperty("error.api.message", aerr.ErrorMessage())
span.SetProperty("error.api.fault", aerr.ErrorFault().String())
span.SetProperty("api.error_code", aerr.ErrorCode())
span.SetProperty("api.error_message", aerr.ErrorMessage())
}
err = &$operationError:T{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ private GoWriter.Writable generateBody() {
ctx = setResolvedAuthScheme(ctx, scheme)
span.SetProperty("operation.auth.resolved_scheme_id", scheme.Scheme.SchemeID())
span.SetProperty("auth.scheme_id", scheme.Scheme.SchemeID())
span.End()
return next.HandleFinalize(ctx, in)
""",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ private GoWriter.Writable generateResolveEndpoint() {
return out, metadata, $fmt.Errorf:T("failed to resolve service endpoint, %w", err)
}
span.SetProperty("operation.resolved_endpoint", endpt.URI.String())
span.SetProperty("client.call.resolved_endpoint", endpt.URI.String())
if endpt.URI.RawPath == "" && req.URL.RawPath != "" {
endpt.URI.RawPath = endpt.URI.Path
Expand Down
12 changes: 6 additions & 6 deletions transport/http/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,14 @@ func (c ClientHandler) Handle(ctx context.Context, input interface{}) (
return nil, metadata, err
}

span.SetProperty("http.request.method", req.Method)
span.SetProperty("http.request.content_length", -1) // at least indicate unknown
span.SetProperty("http.method", req.Method)
span.SetProperty("http.request_content_length", -1) // at least indicate unknown
length, ok, err := req.StreamLength()
if err != nil {
return nil, metadata, err
}
if ok {
span.SetProperty("http.request.content_length", length)
span.SetProperty("http.request_content_length", length)
}

resp, err := c.client.Do(builtRequest)
Expand Down Expand Up @@ -93,9 +93,9 @@ func (c ClientHandler) Handle(ctx context.Context, input interface{}) (
_ = builtRequest.Body.Close()
}

span.SetProperty("http.proto", fmt.Sprintf("%d.%d", resp.ProtoMajor, resp.ProtoMinor))
span.SetProperty("http.response.status_code", resp.StatusCode)
span.SetProperty("http.response.content_length", resp.ContentLength)
span.SetProperty("net.protocol.version", fmt.Sprintf("%d.%d", resp.ProtoMajor, resp.ProtoMinor))
span.SetProperty("http.status_code", resp.StatusCode)
span.SetProperty("http.response_content_length", resp.ContentLength)

return &Response{Response: resp}, metadata, err
}
Expand Down

0 comments on commit 9ac68b5

Please sign in to comment.