Modify and Merge protocol test request unit tests codegen logic #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 11, 2023 16:52
lucix-aws
approved these changes
Aug 17, 2023
isaiahvita
approved these changes
Aug 17, 2023
| writer.addUseImports(SmithyGoDependency.CONTEXT); | ||
| writer.write("result, err := $L.$T(context.Background(), c.Params)", clientName, opSymbol); | ||
| writer.openBlock("result, err := $L.$T(context.Background(), c.Params, func(options *Options) {", "})", |
There was a problem hiding this comment.
nit: in the future, we should avoid using a series of openBlocks like this, and just rely on gofmt to do all the formatting. see something like this
https://github.com/aws/smithy-go/blob/main/codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/endpoints/EndpointMiddlewareGenerator.java#L266
isaiahvita
reviewed
Aug 18, 2023
| @@ -282,7 +274,8 @@ protected void generateTestServer( | |||
| String name, | |||
| Consumer<GoWriter> handler | |||
| ) { | |||
| super.generateTestServer(writer, name, handler); | |||
| // We aren't using a test server, but we do need a URL to set. | |||
There was a problem hiding this comment.
nit: actually this comment doesnt do a lot of good when its generated. because the generated code wont have this comment. if we can, we should make the URL value even more obvious that its a placeholder (while still being parse-able by whatever needs it). for example, would http://thisisa.placeholder:4242 work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify and Merge protocol test request unit tests codegen logic to isolate cases from local server and instead capture and check request directly via middleware