Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time.Duration to the list of Go Stdlib Types #515

Closed
wants to merge 1 commit into from
Closed

Add time.Duration to the list of Go Stdlib Types #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/GoStdlibTypes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public static final class Context {

public static final class Time {
public static final Symbol Time = SmithyGoDependency.TIME.pointableSymbol("Time");
public static final Symbol Duration = SmithyGoDependency.TIME.valueSymbol("Duration");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW we've kind of stopped doing this because there are just too many -- instead we just started calling these directly, and we added some helpers so you can do stuff like

SmithyGoDependency.TIME.struct("Time")

This is fine though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, nah I rather do it The Right Way ™

Will close the PR

}

public static final class Encoding {
Expand Down
Loading