-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add awsJson10 Error Deserialization support. #535
Conversation
Here is the generated code for the deserializers.go file: |
...src/main/java/software/amazon/smithy/go/codegen/protocol/aws/AwsJson10ProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/go/codegen/protocol/aws/AwsJson10ProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/go/codegen/protocol/aws/AwsJson10ProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/go/codegen/protocol/aws/AwsJson10ProtocolGenerator.java
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/go/codegen/protocol/aws/AwsJson10ProtocolGenerator.java
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/go/codegen/protocol/aws/AwsJson10ProtocolGenerator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a TODO here mentioning that we don't cover all errors? From Smithy docs
The component MUST be one of the following: an additional header with the name X-Amzn-Errortype, a body field with the name code, or a body field named __type
We're only covering the 3rd type, body field with __type
Issue #, if available:
Description of changes:
Protocol Generator:
Deserialize Middleware:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.