Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Ran
golint
andmake vet
on the repo.We had an offline discussion about running this always.
golint
is unfortunately deprecated, and there's no easy way to tell the tool "ignore this module/file"find -exec golint
doesn't work as expected since golint expects to be run in the context of a packagegolint ./...
marks singleflight as failing check, so we can't use the exit code to accept/reject a changeLooked into incorporating
golangci-lint
, but the scope of changes it flags doesn't seem too valuable, so I'm a bit hesitant to add it to the default run if we're just going to ignore the result.golint
flagged these changes, which IBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.