Run golint and go vet

document/cbor/decode.go

@@ -48,7 +48,7 @@ func (d *decoder) Decode(v cbor.Value, to interface{}) error {
 
 	rv := reflect.ValueOf(to)
 	if rv.Kind() != reflect.Ptr || rv.IsNil() || !rv.IsValid() {
-		return &document.InvalidUnmarshalError{reflect.TypeOf(to)}
+		return &document.InvalidUnmarshalError{Type: reflect.TypeOf(to)}
 	}
 
 	return d.decode(v, rv, serde.Tag{})

document/cbor/encode.go

@@ -145,7 +145,7 @@ func (e *encoder) encodeMap(rv reflect.Value) (cbor.Map, error) {
 	for _, key := range rv.MapKeys() {
 		keyName := fmt.Sprint(key.Interface())
 		if keyName == "" {
-			return nil, &document.InvalidMarshalError{"map key cannot be empty"}
+			return nil, &document.InvalidMarshalError{Message: "map key cannot be empty"}
 		}
 
 		cv, err := e.encode(rv.MapIndex(key), serde.Tag{})

encoding/cbor/encode.go

@@ -189,7 +189,7 @@ func (v EncodeRaw) encode(p []byte) int {
 	return len(v)
 }
 
-// FixedUint encodes fixed-width Uint values.
+// EncodeFixedUint encodes fixed-width Uint values.
 //
 // This is used by the encoder for the purpose of embedding integrals in
 // document shapes. Decode will never return values of this type.
@@ -203,7 +203,7 @@ func (v EncodeFixedUint) encode(p []byte) int {
 	return 9
 }
 
-// FixedUint encodes fixed-width NegInt values.
+// EncodeFixedNegInt encodes fixed-width NegInt values.
 //
 // This is used by the encoder for the purpose of embedding integrals in
 // document shapes. Decode will never return values of this type.

encoding/doc.go

@@ -1,4 +1,3 @@
 // Package encoding provides utilities for encoding values for specific
 // document encodings.
-
 package encoding

encoding/httpbinding/encode.go

@@ -33,7 +33,7 @@ func NewEncoder(path, query string, headers http.Header) (*Encoder, error) {
 	return NewEncoderWithRawPath(path, path, query, headers)
 }
 
-// NewHTTPBindingEncoder creates a new encoder from the passed in request. All query and
+// NewEncoderWithRawPath creates a new encoder from the passed in request. All query and
 // header values will be added on top of the request's existing values. Overwriting
 // duplicate values.
 func NewEncoderWithRawPath(path, rawPath, query string, headers http.Header) (*Encoder, error) {

endpoints/private/rulesfn/doc.go

@@ -1,4 +1,3 @@
 // Package rulesfn provides endpoint rule functions for evaluating endpoint
 // resolution rules.
-
 package rulesfn

endpoints/private/rulesfn/strings.go

@@ -1,6 +1,6 @@
 package rulesfn
 
-// Substring returns the substring of the input provided. If the start or stop
+// SubString returns the substring of the input provided. If the start or stop
 // indexes are not valid for the input nil will be returned. If errors occur
 // they will be added to the provided [ErrorCollector].
 func SubString(input string, start, stop int, reverse bool) *string {

internal/sync/singleflight/docs.go

@@ -4,5 +4,4 @@
 // and unversioned golang.org/x/sync module.
 //
 // https://github.com/golang/sync/tree/67f06af15bc961c363a7260195bcd53487529a21/singleflight
-
 package singleflight

middleware/stack_values.go

@@ -21,7 +21,7 @@ func ClearStackValues(ctx context.Context) context.Context {
 	return context.WithValue(ctx, stackValuesKey{}, nil)
 }
 
-// GetStackValues returns the value pointed to by the key within the stack
+// GetStackValue returns the value pointed to by the key within the stack
 // values, if it is present.
 func GetStackValue(ctx context.Context, key interface{}) interface{} {
 	md, _ := ctx.Value(stackValuesKey{}).(*stackValues)
@@ -62,13 +62,13 @@ func (m *stackValues) Value(key interface{}) interface{} {
 	return m.parent.Value(key)
 }
 
-func (c *stackValues) String() string {
+func (m *stackValues) String() string {
 	var str strings.Builder
 
-	cc := c
+	cc := m
 	for cc == nil {
 		str.WriteString("(" +
-			reflect.TypeOf(c.key).String() +
+			reflect.TypeOf(m.key).String() +
 			": " +
 			stringify(cc.value) +
 			")")

private/requestcompression/request_compression.go

@@ -10,12 +10,14 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"io"
+
 	"github.com/aws/smithy-go/middleware"
 	"github.com/aws/smithy-go/transport/http"
-	"io"
 )
 
-const MaxRequestMinCompressSizeBytes = 10485760
+// MaxRequestMinCompressSizeBytes is the maximum value allowed for the member MinCompressSizeBytes
+const MaxRequestMinCompressSizeBytes = 10485760 // 10 MB
 
 // Enumeration values for supported compress Algorithms.
 const (

testing/xml/doc.go

@@ -1,6 +1,6 @@
-// package xml is xml testing package that supports xml comparison utility.
+// Package xml is xml testing package that supports xml comparison utility.
 // The package consists of XMLToStruct and StructToXML utils that help sort xml elements
-// as per their nesting level. XMLToStruct function converts an xml document into a sorted
+// as per their nesting level. XMLToStruct function converts a xml document into a sorted
 // tree node structure, while StructToXML converts the sorted xml nodes into a sorted xml document.
-// SortXML function should be used to sort an xml document. It can be configured to ignore indentation
+// SortXML function should be used to sort a xml document. It can be configured to ignore indentation
 package xml

testing/xml/xmlToStruct.go

@@ -8,7 +8,7 @@ import (
 	"strings"
 )
 
-// A XMLNode contains the values to be encoded or decoded.
+// XMLNode contains the values to be encoded or decoded.
 type XMLNode struct {
 	Name     xml.Name              `json:",omitempty"`
 	Children map[string][]*XMLNode `json:",omitempty"`
@@ -159,7 +159,7 @@ func StructToXML(e *xml.Encoder, node *XMLNode, sorted bool) error {
 		sort.Strings(sortedNames)
 
 		for _, k := range sortedNames {
-			// we should sort the []*xml.Node for each key if len >1
+			// we should sort the []*xml.XMLNode for each key if len >1
 			flattenedNodes := node.Children[k]
 			// Meaning this has multiple nodes
 			if len(flattenedNodes) > 1 {

transport/http/headerlist.go

@@ -55,7 +55,7 @@ func quotedCommaSplit(v string) (parts []string, err error) {
 			//------------------------------
 			var j int
 			var skipQuote bool
-			for j += 1; j < len(remaining); j++ {
+			for j ++; j < len(remaining); j++ {
 				if remaining[j] == '\\' || (remaining[j] != '\\' && skipQuote) {
 					skipQuote = !skipQuote
 					continue

transport/http/properties.go

@@ -46,7 +46,7 @@ func SetSigV4ASigningName(p *smithy.Properties, name string) {
 	p.Set(sigV4ASigningNameKey{}, name)
 }
 
-// GetSigV4ASigningRegion gets the v4a signing region set from Properties.
+// GetSigV4ASigningRegions gets the v4a signing region set from Properties.
 func GetSigV4ASigningRegions(p *smithy.Properties) ([]string, bool) {
 	v, ok := p.Get(sigV4ASigningRegionsKey{}).([]string)
 	return v, ok