Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow empty headers on prefix headers #544

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Madrigal
Copy link
Contributor

@Madrigal Madrigal commented Oct 3, 2024

Issue #, if available:
Had an issue where calling S3 with metadata with an empty value caused SDKs to not serialize the value and not send the header. This change allows prefix headers to have an empty value.

Description of changes:
Remove restriction of not serializing empty values for prefix headers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Madrigal Madrigal merged commit 90c085e into main Oct 7, 2024
11 checks passed
@Madrigal Madrigal deleted the fix-allow-empty-prefix-headers branch October 7, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants