Skip to content

Commit

Permalink
Review updates
Browse files Browse the repository at this point in the history
  • Loading branch information
DavidSouther committed Oct 3, 2023
1 parent b4fec30 commit 6b6f25a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
4 changes: 1 addition & 3 deletions .doc_gen/metadata/auto-scaling_metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,7 @@ auto-scaling_DeleteAutoScalingGroup:
- sdk_version: 3
github: python/example_code/auto-scaling
excerpts:
- description:
Update the minimum size of an Auto Scaling group to zero, terminate all
instances in the group, and delete the group.
- description: Update the minimum size of an Auto Scaling group to zero, terminate all instances in the group, and delete the group.
snippet_tags:
- python.cross_service.resilient_service.AutoScaler.decl
- python.cross_service.resilient_service.auto-scaling.DeleteAutoScalingGroup
Expand Down
2 changes: 1 addition & 1 deletion rust_dev_preview/examples/auto-scaling/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "autoscaling-code-examples"
version = "0.1.0"
authors = ["Doug Schwartz <dougsch@amazon.com>", "David Souther <davidsouther+github@gmail.com>"]
authors = ["Doug Schwartz <dougsch@amazon.com>", "David Souther <dpsouth@amazon.com>"]
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
Expand Down
7 changes: 6 additions & 1 deletion rust_dev_preview/examples/auto-scaling/src/scenario.rs
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,12 @@ impl ScenarioError {
}
}

impl Error for ScenarioError {}
impl Error for ScenarioError {
// While `Error` can capture `source` information about the underlying error, for this example
// the ScenarioError captures the underlying information in MetadataError and treats it as a
// single Error from this Crate. In other contexts, it may be appropriate to model the error
// as including the SdkError as its source.
}
impl Display for ScenarioError {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match &self.context {
Expand Down

0 comments on commit 6b6f25a

Please sign in to comment.