Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gov2: create example code for cloudfront #5156

Merged
merged 20 commits into from
Oct 13, 2023
Merged

gov2: create example code for cloudfront #5156

merged 20 commits into from
Oct 13, 2023

Conversation

tae2089
Copy link
Contributor

@tae2089 tae2089 commented Jul 25, 2023

This pull request...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Laren-AWS Laren-AWS self-assigned this Jul 25, 2023
@rlhagerm rlhagerm requested a review from Laren-AWS August 11, 2023 13:50
@rlhagerm rlhagerm added the Go-v2 This issue relates to the AWS SDK for Go V2 label Aug 11, 2023
Laren-AWS
Laren-AWS requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@Laren-AWS Laren-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added a few requested changes to bring this up to our standard.

gov2/cloudfront/CreateDistribution/CreateDistribution.go Outdated Show resolved Hide resolved
gov2/cloudfront/CreateDistribution/CreateDistribution.go Outdated Show resolved Hide resolved
gov2/cloudfront/CreateDistribution/CreateDistribution.go Outdated Show resolved Hide resolved
gov2/cloudfront/CreateDistribution/CreateDistribution.go Outdated Show resolved Hide resolved
gov2/cloudfront/CreateDistribution/CreateDistribution.go Outdated Show resolved Hide resolved
gov2/cloudfront/CreateDistribution/CreateDistribution_test.go Outdated Show resolved Hide resolved
gov2/cloudfront/CreateDistribution/CreateDistribution_test.go Outdated Show resolved Hide resolved
@tae2089
Copy link
Contributor Author

tae2089 commented Sep 22, 2023

@Laren-AWS
Thank you for leaving a comment. I modified the code related to that. I would appreciate it if you could check the modified part.

@Laren-AWS Laren-AWS added On Call Review needed This work needs an on-call review Text Review complete Text review complete Task labels Oct 13, 2023
@ford-at-aws ford-at-aws added Text Review not needed This contains no text which needs review and removed On Call Review needed This work needs an on-call review labels Oct 13, 2023
@ford-at-aws ford-at-aws added On Call Review complete On call review complete and removed Text Review complete Text review complete labels Oct 13, 2023
@ford-at-aws ford-at-aws merged commit 0798eab into awsdocs:main Oct 13, 2023
12 of 15 checks passed
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
@tae2089 @ford-at-aws
gov2: create example code for cloudfront (#5156)
c5f809d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laren-AWS Laren-AWS Laren-AWS approved these changes

Assignees

@Laren-AWS Laren-AWS

Labels
Go-v2 This issue relates to the AWS SDK for Go V2 On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tae2089 @Laren-AWS @ford-at-aws @rlhagerm