Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: ec2 autoscaling scenario #5367

Merged
merged 10 commits into from
Oct 5, 2023
Merged

Rust: ec2 autoscaling scenario #5367

merged 10 commits into from
Oct 5, 2023

Conversation

DavidSouther
Copy link
Contributor

This pull request closes #5365 adding the Autoscaling scenario in Rust with metadata updates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DavidSouther DavidSouther added Rust This issue relates to the AWS SDK for Rust (Preview) MVP A Minimum Viable Product example to show the bare bones of how to use a service via an SDK. labels Sep 8, 2023
@DavidSouther DavidSouther requested review from jdisanti and a team September 8, 2023 17:14
@DavidSouther DavidSouther self-assigned this Sep 8, 2023
@DavidSouther DavidSouther requested review from scmacdon and removed request for a team September 8, 2023 17:14
@DavidSouther DavidSouther force-pushed the rust/scenario/ec2_autoscaling branch from ac9648d to 48caf1e Compare September 8, 2023 23:05
@github-actions github-actions bot added the GitHub settings This affects GitHub settings label Sep 12, 2023
@DavidSouther DavidSouther removed the request for review from jdisanti September 12, 2023 17:06
@DavidSouther DavidSouther force-pushed the rust/scenario/ec2_autoscaling branch from 70778f0 to db0bea2 Compare September 20, 2023 20:19
@DavidSouther DavidSouther requested a review from rcoh September 20, 2023 20:19
@github-actions github-actions bot removed the GitHub settings This affects GitHub settings label Sep 20, 2023
@DavidSouther DavidSouther force-pushed the rust/scenario/ec2_autoscaling branch from db0bea2 to a40bf8e Compare September 20, 2023 20:40
@DavidSouther DavidSouther requested review from a team and ford-at-aws and removed request for scmacdon and a team September 20, 2023 20:43
@DavidSouther DavidSouther added Text Review needed This work needs editorial (text) review and removed Text Review needed This work needs editorial (text) review labels Sep 20, 2023
rcoh
rcoh approved these changes Sep 25, 2023
View reviewed changes
rust_dev_preview/examples/auto-scaling/Cargo.toml Outdated Show resolved Hide resolved
rust_dev_preview/examples/auto-scaling/src/scenario.rs Outdated Show resolved Hide resolved
ford-at-aws
ford-at-aws requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly just the Python metadata change needs explanation. Gmail address is also atypical but could make sense depending on your justification.

@DavidSouther DavidSouther force-pushed the rust/scenario/ec2_autoscaling branch from 66a8e53 to 6d0a59a Compare September 26, 2023 19:49
@DavidSouther DavidSouther added the Text Review needed This work needs editorial (text) review label Sep 26, 2023
@lkdavies lkdavies added Text Review complete Text review complete and removed Text Review needed This work needs editorial (text) review labels Sep 26, 2023
@DavidSouther DavidSouther added the On Call Review needed This work needs an on-call review label Sep 27, 2023
@DavidSouther DavidSouther force-pushed the rust/scenario/ec2_autoscaling branch 4 times, most recently from c2ca714 to 6b6f25a Compare October 3, 2023 16:18
@github-actions github-actions bot removed the GitHub settings This affects GitHub settings label Oct 3, 2023
@DavidSouther DavidSouther force-pushed the rust/scenario/ec2_autoscaling branch from 6b6f25a to ab790c6 Compare October 3, 2023 16:19
@DavidSouther DavidSouther added the On Call Review needed This work needs an on-call review label Oct 3, 2023
@DavidSouther DavidSouther removed the On Call Review needed This work needs an on-call review label Oct 3, 2023
@DavidSouther DavidSouther force-pushed the rust/scenario/ec2_autoscaling branch 2 times, most recently from 6f4c61c to 632153e Compare October 5, 2023 14:40
@DavidSouther DavidSouther added the On Call Review needed This work needs an on-call review label Oct 5, 2023
@rlhagerm rlhagerm force-pushed the rust/scenario/ec2_autoscaling branch from 632153e to 4a690cd Compare October 5, 2023 16:42
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 5, 2023
@rlhagerm rlhagerm merged commit 5b0cb7a into awsdocs:main Oct 5, 2023
14 of 15 checks passed
@DavidSouther DavidSouther deleted the rust/scenario/ec2_autoscaling branch October 23, 2023 15:25
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
@DavidSouther @ford-at-aws
Rust: ec2 autoscaling scenario (#5367)
66e51cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlhagerm rlhagerm rlhagerm approved these changes

@ford-at-aws ford-at-aws ford-at-aws approved these changes

@rcoh rcoh rcoh approved these changes

@lkdavies lkdavies Awaiting requested review from lkdavies

Assignees

@DavidSouther DavidSouther

Labels
MVP A Minimum Viable Product example to show the bare bones of how to use a service via an SDK. On Call Review complete On call review complete Rust This issue relates to the AWS SDK for Rust (Preview) Text Review complete Text review complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust AutoScaling MVP
5 participants
@DavidSouther @rcoh @ford-at-aws @rlhagerm @lkdavies