Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAP ABAP: Add new example in dynamo db #5391

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

dhiraj-thakkar
Copy link
Contributor

This pull request updates SAP ABAP SDK by adding new example for Dynamo DB


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DavidSouther DavidSouther added Text Review needed This work needs editorial (text) review Follow After Scouts, more languages are added to examples as Follows. Task labels Sep 18, 2023
@Laren-AWS Laren-AWS force-pushed the abab-sdk-dyn-example branch from 8158c71 to cc7f747 Compare October 2, 2023 19:32
@Laren-AWS Laren-AWS added On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review and removed Text Review needed This work needs editorial (text) review labels Oct 2, 2023
Copy link
Contributor

@meyertst-aws meyertst-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggestions which are the sort of thing Liz would suggest when she was still reviewing code.
I hope this is correct. I am not sure where it is specified that code comments should end in a period.

sap-abap/services/dyn/zcl_aws1_dyn_actions.clas.abap Outdated Show resolved Hide resolved
sap-abap/services/dyn/zcl_aws1_dyn_actions.clas.abap Outdated Show resolved Hide resolved
sap-abap/services/dyn/zcl_aws1_dyn_actions.clas.abap Outdated Show resolved Hide resolved
sap-abap/services/dyn/zcl_aws1_dyn_scenario.clas.abap Outdated Show resolved Hide resolved
sap-abap/services/dyn/zcl_aws1_dyn_scenario.clas.abap Outdated Show resolved Hide resolved
sap-abap/services/dyn/zcl_aws1_dyn_scenario.clas.abap Outdated Show resolved Hide resolved
sap-abap/services/dyn/zcl_aws1_dyn_scenario.clas.abap Outdated Show resolved Hide resolved
sap-abap/services/dyn/zcl_aws1_dyn_scenario.clas.abap Outdated Show resolved Hide resolved
sap-abap/services/dyn/zcl_aws1_dyn_scenario.clas.abap Outdated Show resolved Hide resolved
sap-abap/services/dyn/zcl_aws1_dyn_scenario.clas.abap Outdated Show resolved Hide resolved
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 5, 2023
Dhiraj Thakkar and others added 2 commits October 5, 2023 11:34
Co-authored-by: Steven Meyer <108885656+meyertst-aws@users.noreply.github.com>
@rlhagerm rlhagerm force-pushed the abab-sdk-dyn-example branch from c348a7c to 09ddded Compare October 5, 2023 16:34
@rlhagerm rlhagerm merged commit a1e3b07 into awsdocs:main Oct 5, 2023
8 checks passed
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
* Add example for SAP ABAP SDK dynamo db

* Apply suggestions from code review

Co-authored-by: Steven Meyer <108885656+meyertst-aws@users.noreply.github.com>

---------

Co-authored-by: Dhiraj Thakkar <dhirajtx@amazon.com>
Co-authored-by: Laren-AWS <57545972+Laren-AWS@users.noreply.github.com>
Co-authored-by: Steven Meyer <108885656+meyertst-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Follow After Scouts, more languages are added to examples as Follows. On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants