-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAP ABAP: Add new example in dynamo db #5391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSouther
added
Text Review needed
This work needs editorial (text) review
Follow
After Scouts, more languages are added to examples as Follows.
Task
labels
Sep 18, 2023
Laren-AWS
force-pushed
the
abab-sdk-dyn-example
branch
from
October 2, 2023 19:32
8158c71
to
cc7f747
Compare
Laren-AWS
approved these changes
Oct 2, 2023
Laren-AWS
added
On Call Review needed
This work needs an on-call review
Text Review not needed
This contains no text which needs review
and removed
Text Review needed
This work needs editorial (text) review
labels
Oct 2, 2023
meyertst-aws
requested changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have suggestions which are the sort of thing Liz would suggest when she was still reviewing code.
I hope this is correct. I am not sure where it is specified that code comments should end in a period.
meyertst-aws
approved these changes
Oct 4, 2023
rlhagerm
added
On Call Review complete
On call review complete
and removed
On Call Review needed
This work needs an on-call review
labels
Oct 5, 2023
Co-authored-by: Steven Meyer <108885656+meyertst-aws@users.noreply.github.com>
rlhagerm
force-pushed
the
abab-sdk-dyn-example
branch
from
October 5, 2023 16:34
c348a7c
to
09ddded
Compare
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
* Add example for SAP ABAP SDK dynamo db * Apply suggestions from code review Co-authored-by: Steven Meyer <108885656+meyertst-aws@users.noreply.github.com> --------- Co-authored-by: Dhiraj Thakkar <dhirajtx@amazon.com> Co-authored-by: Laren-AWS <57545972+Laren-AWS@users.noreply.github.com> Co-authored-by: Steven Meyer <108885656+meyertst-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Follow
After Scouts, more languages are added to examples as Follows.
On Call Review complete
On call review complete
Text Review not needed
This contains no text which needs review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates SAP ABAP SDK by adding new example for Dynamo DB
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.