Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Resilient service workflow followup #5393

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Python: Resilient service workflow followup #5393

merged 2 commits into from
Sep 19, 2023

Conversation

Laren-AWS
Copy link
Contributor

Followup to previous resilient service workflow scout:

  • Unit and integration tests
  • Metadata and tags
  • Specification for rest of team to follow
  • Hello service

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Laren-AWS Laren-AWS self-assigned this Sep 15, 2023
@github-actions github-actions bot added the Python This issue relates to the AWS SDK for Python (boto3) label Sep 15, 2023
@Laren-AWS Laren-AWS added Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. Scout An example which other languages will use for reference later on. Python This issue relates to the AWS SDK for Python (boto3) On Call Review needed This work needs an on-call review Text Review needed This work needs editorial (text) review and removed Python This issue relates to the AWS SDK for Python (boto3) labels Sep 15, 2023
@Laren-AWS Laren-AWS requested a review from lkdavies September 15, 2023 23:33
@github-actions github-actions bot added the GitHub settings This affects GitHub settings label Sep 15, 2023
lkdavies
lkdavies reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

.doc_gen/metadata/ec2_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/ec2_metadata.yaml Outdated Show resolved Hide resolved
python/example_code/auto-scaling/README.md Outdated Show resolved Hide resolved
python/example_code/auto-scaling/README.md Outdated Show resolved Hide resolved
python/example_code/auto-scaling/README.md Outdated Show resolved Hide resolved
workflows/resilient_service/SPECIFICATION.md Outdated Show resolved Hide resolved
workflows/resilient_service/SPECIFICATION.md Outdated Show resolved Hide resolved
workflows/resilient_service/SPECIFICATION.md Outdated Show resolved Hide resolved
workflows/resilient_service/SPECIFICATION.md Outdated Show resolved Hide resolved
workflows/resilient_service/SPECIFICATION.md Outdated Show resolved Hide resolved
@lkdavies lkdavies added Text Review complete Text review complete and removed Text Review needed This work needs editorial (text) review labels Sep 18, 2023
DavidSouther
DavidSouther requested changes Sep 18, 2023
View reviewed changes
.doc_gen/readmes/render.py Outdated Show resolved Hide resolved
python/cross_service/resilient_service/test/conftest.py Outdated Show resolved Hide resolved
python/cross_service/resilient_service/test/resources/server.py Outdated Show resolved Hide resolved
python/cross_service/resilient_service/test/test_demo.py Outdated Show resolved Hide resolved
python/example_code/ec2/README.md Outdated Show resolved Hide resolved
@Laren-AWS Laren-AWS force-pushed the resilient-service-fast-follow branch 3 times, most recently from ea9ec8d to fa069e5 Compare September 18, 2023 22:26
@beqqrry-aws beqqrry-aws force-pushed the resilient-service-fast-follow branch from fa069e5 to 9e757ed Compare September 19, 2023 17:45
@beqqrry-aws beqqrry-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Sep 19, 2023
@beqqrry-aws beqqrry-aws merged commit 6056d24 into awsdocs:main Sep 19, 2023
13 of 14 checks passed
@Laren-AWS Laren-AWS deleted the resilient-service-fast-follow branch June 10, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beqqrry-aws beqqrry-aws beqqrry-aws left review comments

@lkdavies lkdavies lkdavies left review comments

@DavidSouther DavidSouther DavidSouther approved these changes

Assignees

@Laren-AWS Laren-AWS

Labels
GitHub settings This affects GitHub settings On Call Review complete On call review complete Python This issue relates to the AWS SDK for Python (boto3) Scout An example which other languages will use for reference later on. Text Review complete Text review complete Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Laren-AWS @DavidSouther @lkdavies @beqqrry-aws