Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript (v3) - SageMaker Pipelines Workflow #5403

Merged
merged 3 commits into from
Sep 25, 2023
Merged

JavaScript (v3) - SageMaker Pipelines Workflow #5403

merged 3 commits into from
Sep 25, 2023

Conversation

cpyle0819
Copy link
Contributor

This pull request adds the SageMaker pipelines code example.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added On Call Review needed This work needs an on-call review Text Review needed This work needs editorial (text) review labels Sep 21, 2023
@cpyle0819 cpyle0819 requested a review from rlhagerm as a code owner September 21, 2023 18:45
@cpyle0819 cpyle0819 self-assigned this Sep 21, 2023
@github-actions github-actions bot added DotNet-v3 This issue relates to the AWS SDK for .NET V3 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 Kotlin This issue relates to the AWS SDK for Kotlin Java-v2 This issue relates to the AWS SDK for Java V2 GitHub settings This affects GitHub settings labels Sep 21, 2023
@cpyle0819 cpyle0819 force-pushed the corepyle/workflow/5294 branch 2 times, most recently from 5b92c02 to f7065a5 Compare September 22, 2023 14:04
@github-actions github-actions bot removed DotNet-v3 This issue relates to the AWS SDK for .NET V3 Kotlin This issue relates to the AWS SDK for Kotlin Java-v2 This issue relates to the AWS SDK for Java V2 GitHub settings This affects GitHub settings labels Sep 22, 2023
lkdavies
lkdavies reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

.doc_gen/metadata/sagemaker_metadata.yaml Outdated Show resolved Hide resolved
javascriptv3/example_code/sagemaker/scenarios/wkflw-sagemaker-geospatial-pipeline/messages.js Outdated Show resolved Hide resolved
javascriptv3/example_code/sagemaker/scenarios/wkflw-sagemaker-geospatial-pipeline/messages.js Outdated Show resolved Hide resolved
@lkdavies lkdavies added Text Review complete Text review complete and removed Text Review needed This work needs editorial (text) review labels Sep 22, 2023
rlhagerm
rlhagerm approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues, only small questions. LGTM!

...mple_code/sagemaker/scenarios/wkflw-sagemaker-geospatial-pipeline/SageMakerPipelinesWkflw.js Outdated Show resolved Hide resolved
javascriptv3/example_code/sagemaker/scenarios/wkflw-sagemaker-geospatial-pipeline/messages.js Show resolved Hide resolved
javascriptv3/example_code/sagemaker/scenarios/wkflw-sagemaker-geospatial-pipeline/messages.js Outdated Show resolved Hide resolved
@cpyle0819 cpyle0819 mentioned this pull request Sep 25, 2023
Merged
@beqqrry-aws beqqrry-aws force-pushed the corepyle/workflow/5294 branch from 76e287b to 53ed68d Compare September 25, 2023 16:52
@beqqrry-aws beqqrry-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Sep 25, 2023
@cpyle0819 cpyle0819 added the Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. label Sep 25, 2023
@beqqrry-aws beqqrry-aws merged commit 38f6eb4 into awsdocs:main Sep 25, 2023
14 of 18 checks passed
@cpyle0819 cpyle0819 deleted the corepyle/workflow/5294 branch September 25, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkdavies lkdavies lkdavies left review comments

@rlhagerm rlhagerm rlhagerm approved these changes

Assignees

@cpyle0819 cpyle0819

Labels
Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Text Review complete Text review complete Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpyle0819 @lkdavies @rlhagerm @beqqrry-aws