JavaScript (v3): Ramdectomy #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
added
Text Review not needed
cpyle0819
requested review from
beqqrry-aws and
a team
and removed request for
a team and
beqqrry-aws
github-actions
bot
added
Javascript-v3
cpyle0819
requested review from
a team and
ford-at-aws
and removed request for
a team
ford-at-aws
added
On Call Review complete
ford-at-aws
added a commit
that referenced
this pull request
Dec 15, 2023
* JavaScript (v3): Ramdaectomy - Remove ramda usage from cognito-identity-provider. * JavaScript (v3): Ramdaectomy - Remove ramda usage from aurora-serverless-app. * JavaScript (v3): Ramdaectomy - Remove ramda usage from glue. * JavaScript (v3): Ramdaectomy - Remove ramda usage from lambda. * JavaScript (v3): Ramdaectomy - Remove ramda usage cmd-runner. * JavaScript (v3): Ramdaectomy - Remove remaining ramda usage. * JavaScript (v3): Ramdaectomy - Add missing copyright. --------- Co-authored-by: ford prior <108086978+ford-at-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes Ramda from the codebase. Ramda usage makes the code difficult to read and the library is poorly typed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.