JavaScript (v3): Integration test fix #7165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Javascript-v3
beqqrry-aws
approved these changes
Dec 18, 2024
CDK Synth does not behave as we expected. It does not deploy assets. CDK deploy is required in order to upload assets. Removed SDK usage of CFN to create the stack and replaced it with a child process running CDK deploy.
ford-at-aws
force-pushed
the
corepyle/integration-tests
branch
from
d93c784 to
788cd8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDK Synth does not behave as we expected. It does not deploy assets. CDK deploy is required in order to upload assets. Removed SDK usage of CFN to create the stack and replaced it with a child process running CDK deploy.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.