Merge pull request #20 from LeonLuttenberger/chore/lint-one-click-tem…

…plate

chore: Add validation step for one-click template

.github/workflows/module-checks.yml

@@ -2,14 +2,22 @@ name: Module Checks
 
 on:
   push:
-    branches: ["main"]
-    paths: ['modules/**', '.github/workflows/module-checks.yml']
+    branches: 
+      - "main"
+    paths:
+      - "modules/**"
+      - "requirements-dev.txt"
+      - ".github/workflows/module-checks.yml"
 
   pull_request:
-    branches: ["main", "release/*", "stable"]
-    paths: ['modules/**', '.github/workflows/module-checks.yml']
-
-  workflow_dispatch:
+    branches:
+      - "main"
+      - "release/*"
+      - "stable"
+    paths:
+      - "modules/**"
+      - "requirements-dev.txt"
+      - ".github/workflows/module-checks.yml"
 
 jobs:
   get-modules:

.github/workflows/one-click-template-lint.yml

@@ -0,0 +1,42 @@
+name: Check One-Click Launch Template
+
+on:
+  push:
+    branches: 
+      - "main"
+    paths:
+      - "one-click-launch.yaml"
+      - "requirements-dev.txt"
+      - ".github/workflows/one-click-template-lint.yml"
+
+  pull_request:
+    branches:
+      - "main"
+      - "release/*"
+      - "stable"
+    paths:
+      - "one-click-launch.yaml"
+      - "requirements-dev.txt"
+      - ".github/workflows/one-click-template-lint.yml"
+
+jobs:
+  lint:
+    name: CFN Lint Template
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: 3.11
+      - name: Install Requirements
+        run: |
+          set -x
+          python -m pip install --upgrade pip
+          pip install -r requirements-dev.txt
+      - name: Lint
+        run: cfn-lint --template ./one-click-launch.yaml

one-click-launch.yaml

@@ -226,8 +226,8 @@ Resources:
               Resource: 
               - !Sub "arn:aws:s3:::codeseeder-mlops-${AWS::AccountId}-*"
               - !Sub "arn:aws:s3:::codeseeder-mlops-${AWS::AccountId}-*/*"
-              - !Sub "arn:aws:s3:::mlops*"
-              - !Sub "arn:aws:s3:::mlops*/*"
+              - "arn:aws:s3:::mlops*"
+              - "arn:aws:s3:::mlops*/*"
             - Sid: CodebuildCleanup
               Effect: Allow
               Action:
@@ -240,7 +240,7 @@ Resources:
       Description: Builds MLOps Solution Using Seedfarmer
       ServiceRole: !GetAtt 'CodeBuildRole.Arn'
       Artifacts:
-        Type: no_artifacts
+        Type: NO_ARTIFACTS
       TimeoutInMinutes: 480
       Environment:
         Type: LINUX_CONTAINER

requirements-dev.txt

@@ -5,7 +5,7 @@ pylint~=2.14.1
 mypy~=0.961
 pip-tools~=6.6.2
 python-dotenv~=0.21.0
-cfn-lint~=0.61.0
+cfn-lint~=0.85.3
 check-manifest~=0.48
 pydot~=1.4.2
 pyroma~=4.0
@@ -17,4 +17,4 @@ types-PyYAML~=6.0.8
 types-setuptools~=57.4.17
 wheel~=0.37.1
 cdk-nag==2.12.29
-click==8.0.2
+click==8.0.2